DS-4218 - Support for second "initialize-entities" #2404
Conversation
…traint to RelationshipType table based on types and labels
benbosman
added
component: configurable entities
|
I just opened a pr at atmire#15 to fix a minor problem with the indentation. |
…update Small indentation fix
|
Thanks @AlexanderS, I've merged it |
There was a problem hiding this comment.
@benbosman : the code here looks fine to me, but the new test has some incorrect comments and needs a better description. I'm not sure exactly what it is supposed to be testing.
| .andExpect(jsonPath("$.page.totalElements", is(10))) | ||
| //There needs to be a self link to this endpoint | ||
| .andExpect(jsonPath("$._links.self.href", containsString("api/core/relationshiptypes"))) | ||
| //We have 4 facets in the default configuration, they need to all be present in the embedded section |
| .andExpect(jsonPath("$.page.totalElements", is(10))) | ||
| //There needs to be a self link to this endpoint | ||
| .andExpect(jsonPath("$._links.self.href", containsString("api/core/relationshiptypes"))) | ||
| //We have 4 facets in the default configuration, they need to all be present in the embedded section |
There was a problem hiding this comment.
This comment is also incorrect. Could we better describe this test in general. It's not straightforward what we are looking for... are we simply verifying running this command twice results in a no-op? Are we looking for specific changes? This test needs some better comments in general.
|
|
||
| //We expect a 200 OK status | ||
| .andExpect(status().isOk()) | ||
| //The type has to be 'discover' |
|
|
||
| //We expect a 200 OK status | ||
| .andExpect(status().isOk()) | ||
| //The type has to be 'discover' |
Missing context complete, this was lost in the previous commit from this PR
|
Thanks for the review @tdonohue Let me know if there's something unclear about the concept of the IT still |
There was a problem hiding this comment.
Thanks @benbosman and @Raf-atmire . The updates look great to me now. Merging into configurable_entities branch.
Executing InitializeEntities multiple times to update the schema used to work, but was broken in #2383 by changing the concept of creating relationship types.
The
InitializeEntitiesimplementation has been updated to solve this problem and a unique constraint to the RelationshipType table has been created based on types and labelsThis solves https://jira.duraspace.org/browse/DS-4218