[DS-4084] - Relationships should link to Items via REST API #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbosman
added
component: configurable entities
…eftid-rightid-relationship
AlexanderS
approved these changes
Jul 2, 2019
paulo-graca
approved these changes
Jul 2, 2019
There was a problem hiding this comment.
It looks good to me. I've just performed some tests and everything worked as expected. Thank you @benbosman !
|
This PR has received 2 approvals, from the people who did volunteer to review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is the last step to support https://jira.duraspace.org/browse/DS-4084
Using the commits in this PR, the leftId and rightId properties are removed.
This can be merged now since DSpace/dspace-angular#408 is merged
This PR will result in a relationship similar to e.g.:
{ "id": 2095, "relationshipTypeId": 0, "leftPlace": 0, "rightPlace": 0, "type": "relationship", "_links": { "relationshipType": { "href": "https://dspace7-entities.atmire.com/rest/api/core/relationshiptypes/12" }, "self": { "href": "https://dspace7-entities.atmire.com/rest/api/core/relationships/2095" }, "leftItem": { "href": "https://dspace7-entities.atmire.com/rest/api/core/items/96715576-3748-4761-ad45-001646632963" }, "rightItem": { "href": "https://dspace7-entities.atmire.com/rest/api/core/items/6eccc640-ca98-486b-9895-723117398a50" } } }