Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DS-3849] REST API items resource returns items in non-deterministic order (further 6.x changes) #2501

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

PhilipVis
Copy link
Contributor

Continuation of the work in #2460.

This PR updates the ItemDAOImpl class to make sure all item lists returned by this class will now be in a deterministic order.

Jira Issue: https://jira.duraspace.org/browse/DS-3849

@PhilipVis PhilipVis changed the base branch from master to dspace-6_x September 4, 2019 13:35
@tdonohue tdonohue added bug port to main This PR needs to be ported to `main` branch for the next major release quick win Pull request is small in size & should be easy to review and/or merge labels Sep 4, 2019
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Changes seem fine to me. However, both this PR and the original #2460 PR must also be applied to master. Otherwise, these fixes will not be carried forward (which is obviously not ideal). Please also create a PR to apply both of these to our master branch. Thanks!

@kshepherd kshepherd changed the title Ds 3849 [DS-3849] REST API items resource returns items in non-deterministic order (further 6.x changes) Sep 18, 2019
Copy link
Member

@kshepherd kshepherd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Merging this so it makes it in for 6.4 - the master port #2515 is still failing some tests (seems to be seeing Public Item 3 where it expects Public Item 2 -- and I assume the fault is with the tests?) but this code looks good and behaves well in 6.x. Thanks @PhilipVis

@kshepherd
Copy link
Member

Actually - first, I'm just going to Close and re-open this PR so we can trigger the Travis CI build again which seemed to stall, and is too old for me to find in the Travis build list

@kshepherd kshepherd closed this Feb 19, 2020
@kshepherd kshepherd reopened this Feb 19, 2020
@kshepherd kshepherd merged commit bbc5ca7 into DSpace:dspace-6_x Feb 19, 2020
@kshepherd kshepherd added this to the 6.4 milestone Feb 19, 2020
@kshepherd kshepherd self-assigned this Feb 19, 2020
juliapim pushed a commit to juliapim/DSpace-1 that referenced this pull request Dec 9, 2020
[DS-3849] REST API items resource returns items in non-deterministic order (further 6.x changes)
@tdonohue tdonohue removed the port to main This PR needs to be ported to `main` branch for the next major release label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug quick win Pull request is small in size & should be easy to review and/or merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants