DS-4271: Replaced brackets with double quotes in SolrServiceImpl. #2543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdonohue
added
bug
component: Discovery
nwoodward
approved these changes
Mar 2, 2020
|
Agree this is a good fix for a problem I didn't even realize we had. Tested with a contains filter with spaces on a subject term in our staging repository. Before, 293 results, of which many are not what the user would expect:
After, 162 results, of which all are exactly matching the search term:
Looks good to me for DSpace 6.4. Merge! |
alanorth
pushed a commit
to ilri/DSpace
that referenced
this pull request
Jun 23, 2021
Pending in the 6.4 merge queue. Original: DSpace#2543
|
I haven't tested this but it's got +3 @kshepherd |
|
@J4bbi I think this is a good one for 6.4. It's at +3 for some months now. |
alanorth
approved these changes
May 4, 2022
|
Ported to |
tdonohue
pushed a commit
that referenced
this pull request
May 6, 2022
Port of GitHub PR #2543 from DSpace 6.x to DSpace 7.x, originally by @jonas-atmire. Resolves DS-4271 (GitHub Issue #7611).
tdonohue
removed
the
port to main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DSpace 6 versions of the fix provided in:
https://jira.duraspace.org/browse/DS-4271
Fixes #7611
Quite a small fix, but it has been open for a little while now, so took the liberty to create a quick PR
(More information is present in the JIRA ticket itself)