Entities: configuring whether name variants should be used #2561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbosman
added
the
component: configurable entities
paulo-graca
reviewed
Nov 5, 2019
There was a problem hiding this comment.
I didn't yet test it, but it looks good to me! Thank you @benbosman !
|
I've just test it and it exposes the form configs as expected. |
tdonohue
reviewed
Nov 5, 2019
There was a problem hiding this comment.
@benbosman : Overall this code looks good to me. However, I had a few minor questions here about the usage of @Nullable in the Matcher...I'm not sure it's necessary, and it looks like if nameVariants is actually null the Matcher would throw a NPE.
dspace-api/src/test/data/dspaceFolder/config/submission-forms.xml
Outdated
Show resolved
Hide resolved
dspace-server-webapp/src/test/java/org/dspace/app/rest/matcher/SubmissionFormFieldMatcher.java
Outdated
Show resolved
Hide resolved
dspace-server-webapp/src/test/java/org/dspace/app/rest/matcher/SubmissionFormFieldMatcher.java
Outdated
Show resolved
Hide resolved
paulo-graca
approved these changes
Nov 12, 2019
benbosman
deleted the
w2p-65570_Configuring-whether-name-variants-should-be-used
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the REST implementation of DSpace/RestContract#77
It allows for configuration specifying whether the entities lookup should present the dropdown to enter name variants