Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS-4379 Stop adding relations as metadata for new items #2568

Merged
merged 1 commit into from Nov 19, 2019

Conversation

cwilper
Copy link
Contributor

@cwilper cwilper commented Nov 5, 2019

This fixes a bug where metadatavalue rows were incorrectly added on CSV import, when the item was new, and it had relationships to another item. The relationships should only be persisted in the database relationship table, not metadatavalue.

https://jira.duraspace.org/browse/DS-4379

Copy link
Contributor

@paulo-graca paulo-graca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR fixes the issue DS-4379. Thank you @cwilper for this patch!

Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks like an obvious fix to the described bug. Thanks @cwilper

@tdonohue tdonohue merged commit 7b90332 into DSpace:master Nov 19, 2019
@benbosman benbosman deleted the DS-4379_Omit-metadatvalue-rels branch March 13, 2020 16:10
@tdonohue tdonohue added this to the 7.0beta1 milestone Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants