Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the RelationshipTypeId from Relationship endpoints #2745

Conversation

benbosman
Copy link
Member

References

Description

The relationship still contained a relationshipTypeId while it was replaced with a relationshipType HAL link a long time ago. This old and incorrect property has been removed

Instructions for Reviewers

This is an unused legacy property, it's not used

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
  • My PR passes Checkstyle validation based on the Code Style Guide
  • My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
  • My PR passes all tests and includes new/updated Unit or Integration Tests for any bug fixes, improvements or new features. A few reminders about what constitutes good tests:
    • Include tests for different user types, including: (1) Anonymous user, (2) Logged in user (non-admin), and (3) Administrator.
    • Include tests for known error scenarios and error codes (e.g. 400 Bad Request, 401 Unauthorized, 403 Forbidden, 404 Not Found, etc)
    • For bug fixes, include a test that reproduces the bug and proves it is fixed. For clarity, it may be useful to provide the test in a separate commit from the bug fix.
  • If my PR includes new, third-party dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR modifies the REST API, I've linked to the REST Contract page (or open PR) related to this change.

@benbosman benbosman added the component: configurable entities Related to Configurable Entities feature label Apr 14, 2020
Copy link
Contributor

@paulo-graca paulo-graca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it yet, but this change looks ok to me.

@tdonohue tdonohue changed the base branch from master to main July 13, 2020 21:48
@tdonohue tdonohue self-requested a review July 30, 2020 14:24
@tdonohue tdonohue closed this Jul 30, 2020
@tdonohue tdonohue reopened this Jul 30, 2020
@tdonohue
Copy link
Member

Closing & reopening to trigger a fresh Travis rebuild. Travis hasn't rebuilt in some time & want to verify this still works fine for main (likely it does).

Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Changes here look fine. Assuming Travis rebuild (triggered a moment ago) works, this can be merged.

@tdonohue tdonohue merged commit f06c532 into DSpace:main Jul 31, 2020
@tdonohue tdonohue added this to the 7.0beta4 milestone Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: configurable entities Related to Configurable Entities feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants