This is an alternative PR for DS-4487 that also include test to proof the issue and solution #2750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdonohue
approved these changes
Apr 21, 2020
There was a problem hiding this comment.
👍 Looks great to me, @Micheleboychuk . Thanks for adding this alternative, as I agree it's a better approach than my quick fix in #2749 .
The code here looks good. I found a very minor problem in the ITs, but I corrected it myself (see that latest commit). Once Travis approves again, I think this is ready to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes bug described here: https://jira.lyrasis.org/browse/DS-4487
Related to #2719 (where the bug was accidentally introduced)
Description
Fixes ConcurrentModificationException by ensuring that the List of metadata in getPermissionFilteredMetadata() is not modified while looping through its values.
See Ticket for how to reproduce this bug easily on the /api/core/collections endpoint.