Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HAL Browser Dependencies with latest JQuery, Toastr #2769

Merged
merged 6 commits into from
Jun 4, 2020

Conversation

tdonohue
Copy link
Member

References

Description

Updates our locally customized HAL Browser to latest version of JQuery and Toastr

Instructions for Reviewers

Test the HAL Browser and especially the login screen. As long as behavior is unchanged, then this upgrade succeeds.

List of changes in this PR:

  • Upgrades JQuery to v3.5.1
  • Upgrades Toastr (used to create the success/failure notification on login page) to v2.1.4
  • Updates our Server webapp to pull in both of these dependencies via WebJars.org
  • Also corrects the License headers in the third-party files customized from the HAL Browser

@tdonohue tdonohue added bug high priority interface: REST API v7+ REST API for v7 and later (dspace-server-webapp module) labels May 21, 2020
Copy link
Member

@KevinVdV KevinVdV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a review, didn't see any issues in the code. Built the code locally & could login & access protected endpoint as well.

@jtimal
Copy link

jtimal commented Jun 4, 2020

Okay, update to the jQuery v3.5.1 version, download the dependencies well and navigate well in some sections

@tdonohue
Copy link
Member Author

tdonohue commented Jun 4, 2020

Merging as this is at +2

@tdonohue tdonohue merged commit 3fc20eb into DSpace:master Jun 4, 2020
@tdonohue tdonohue deleted the update_hal_browser_dependencies branch June 4, 2020 15:46
@tdonohue tdonohue added this to the 7.0beta3 milestone Jun 30, 2020
@tdonohue tdonohue added this to Needs Reviewers Assigned in DSpace 7 Beta 3 via automation Jun 30, 2020
@tdonohue tdonohue moved this from Needs Reviewers Assigned to Done in DSpace 7 Beta 3 Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug high priority interface: REST API v7+ REST API for v7 and later (dspace-server-webapp module)
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants