Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple dsoType values in discovery #2909

Merged

Conversation

benbosman
Copy link
Member

@benbosman benbosman commented Jul 29, 2020

References

Description

This is a minor change to support e.g. /server/api/discover/search/objects?dsoType=Collection&dsoType=Community to return communities and collections

We discovered this was relevant to create the Angular UI to import or export a CSV, where a collection or community should be selected (and both should be selectable)

Instructions for Reviewers

There's no need to reindex data. You can test it using:

  • no dsoType parameter
  • /server/api/discover/search/objects?dsoType=Collection&dsoType=Community
  • /server/api/discover/search/objects?dsoType=Item
  • /server/api/discover/search/objects?dsoType=Item&dsoType=Collection

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
  • My PR passes Checkstyle validation based on the Code Style Guide.
  • My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
  • My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR modifies the REST API, I've linked to the REST Contract page (or open PR) related to this change.

@benbosman benbosman added this to the 7.0beta4 milestone Jul 29, 2020
@benbosman benbosman added this to Needs Reviewers Assigned in DSpace 7 Beta 4 via automation Jul 29, 2020
@tdonohue tdonohue added component: Discovery Related to Discovery search or browse system improvement labels Jul 29, 2020
@benbosman benbosman changed the title taskid 71899 Support multiple dsoType values Support multiple dsoType values in discovery Jul 29, 2020
@tdonohue tdonohue self-requested a review July 30, 2020 14:50
@tdonohue tdonohue added the 1 APPROVAL pull request only requires a single approval to merge. label Jul 30, 2020
@tdonohue tdonohue moved this from Needs Reviewers Assigned to Under Review in DSpace 7 Beta 4 Jul 30, 2020
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me overall, @benbosman ! I've tested it manually and it works.

A few very minor requests before we merge...I'd just like us to add JavaDocs to the new methods. Beyond that, this will be ready to merge once JavaDocs are added.

DSpace 7 Beta 4 automation moved this from Under Review to Reviewer Approved Jul 31, 2020
@benbosman
Copy link
Member Author

@tdonohue Samuel has added the JavaDocs

Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benbosman and @samuelcambien ! Merging now

@tdonohue tdonohue merged commit 2027b03 into DSpace:main Aug 5, 2020
DSpace 7 Beta 4 automation moved this from Reviewer Approved to Done Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge. component: Discovery Related to Discovery search or browse system improvement
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants