[DS-1190] Google Analytics tracking support for JSPUI #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 Looks good to me. I'm OK with the JSPUI & XMLUI having separate configs in this scenario, especially since I'd anticipate that someday we'll want to have separate 'jspui.cfg' and 'xmlui.cfg' files (rather than keeping those configs all lumped inside dspace.cfg). |
ghost
pushed a commit
that referenced
this pull request
Aug 7, 2012
[DS-1190] Google Analytics tracking support for JSPUI
ghost
merged commit
artlowel
referenced
this pull request
in atmire/DSpace
Jun 13, 2014
[DS-1190] Google Analytics tracking support for JSPUI
alanorth
referenced
this pull request
in alanorth/DSpace
Dec 10, 2014
alanorth
referenced
this pull request
in alanorth/DSpace
Dec 10, 2014
alanorth
referenced
this pull request
in alanorth/DSpace
Dec 10, 2014
alanorth
referenced
this pull request
in alanorth/DSpace
Dec 11, 2014
hardyoyo
pushed a commit
to hardyoyo/DSpace
that referenced
this pull request
Oct 12, 2015
re DSpace#1496 revised fontstack to match MU style guidelines
hardyoyo
added a commit
to hardyoyo/DSpace
that referenced
this pull request
Oct 10, 2017
* [VSIM-49] add back the sidebar for item pages * [VSIM-49] show the sidebar for any admin on all pages
hardyoyo
added a commit
to hardyoyo/DSpace
that referenced
this pull request
Dec 15, 2017
* [VSIM-49] add back the sidebar for item pages * [VSIM-49] show the sidebar for any admin on all pages
antoine-atmire
referenced
this pull request
in atmire/DSpace
Oct 10, 2018
…onent PageNotFound Component
hardyoyo
added a commit
to hardyoyo/DSpace
that referenced
this pull request
Nov 28, 2018
* [VSIM-49] add back the sidebar for item pages * [VSIM-49] show the sidebar for any admin on all pages
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GA tracking code to the jspui dependent on configuration.
This request is an alternative to an earlier pull request for DS-1190 that seems to have stalled.
It is worth noting that I have chosen to add a new property to dspace.cfg equivalent to that which already exists for the XMLUI. My recollection of earlier discussions was that there was a consensus that the config for the JSPUI and XMLUI should be independent of each other even at the expense of having some duplication.