Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coar 3.0 resource types #8439

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

FelixNicol
Copy link

@FelixNicol FelixNicol commented Aug 2, 2022

Creating a Resource Type entity based on COAR Resource Types 3.0

References

Add references/links to any related issues or PRs. These may include:

Description

Creating a Resource Type entity based on COAR Resource Types 3.0. New entity, relationships, metadatas, submission process and discovery configurations.

Instructions for Reviewers

  • To setup the environment for resource types
  • New metadata types :
  • dspace registry-loader -metadata ./config/registries/relationship-formats.xml    
    
  • dspace registry-loader -metadata ./config/registries/schema-resource-types.xml
    
  • This PR requires to rebuild entities relationships with :
  • \dspace initialize-entities -f [dspace]\config\entities\relationship-types.xml
    
  • This PR requires to rebuild Discovery Solr Indexes with :
  • [dspace]/bin/dspace index-discovery -b 
    
  • A new collection for resource types with the entity type ResourceType
  • To enable ResourceType submission form, add corresponding collection handle in submission-forms.xml
  • ResourceType's relation field is currently commented in submission-forms.xml's publicationStep. To use this feature in the publication step, uncomment it and comment dc.type value-pair field instead.

List of changes in this PR:

  • There is no change in .java files in this pull request, only .xml configurations
  • item-submission.xml : new step and process for ResourceType
  • submission-forms.xml : new form to add ResourceTypes and new field in publicationStep as a comment.
  • relationship-types.xml : new relationship between ResourceType and Publication
  • relationship-formats.xml : new metadatas for the new relationship
  • discovery.xml : ResourceType search and facets
  • virtual-metadata.xml : New virtual metadata to display the resource type in the publication
  • schema-resource-types.xml : new metadatas for the ResourceType

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
  • My PR passes Checkstyle validation based on the Code Style Guide.
  • [n/a] My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
  • My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
  • [n/a ] If my PR includes new, third-party dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • [n/a] If my PR modifies the REST API, I've linked to the REST Contract page (or open PR) related to this change.

… entity, relationships, metadatas, submission process and discovery configurations.
@FelixNicol
Copy link
Author

Working on the failed integration tests

@tdonohue tdonohue added component: configurable entities Related to Configurable Entities feature new feature labels Aug 23, 2022
@github-actions github-actions bot added the merge conflict PR has a merge conflict that needs resolution label Feb 14, 2023
@github-actions
Copy link

Hi @FelixNicol,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: configurable entities Related to Configurable Entities feature merge conflict PR has a merge conflict that needs resolution new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating a Resource Type entity based on COAR Resource Types 3.0
2 participants