Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added WebVTT to default supported bitstream formats #8727

Conversation

alexandrevryghem
Copy link
Member

@alexandrevryghem alexandrevryghem commented Mar 19, 2023

References

Description

While working on PR 2156 I saw that the WebVTT bitstream type was not listed in the default bitstreams format.

Instructions for Reviewers

List of changes in this PR:

  • Added the WebVTT bitstream type.

Guidance for how to test or review this PR:

  • Create a new DB and run the migrations
  • Check that when you upload a new *.vtt bitstream the WebVTT format is selected by default

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
  • My PR passes Checkstyle validation based on the Code Style Guide.
  • My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
  • My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
  • If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@alexandrevryghem alexandrevryghem self-assigned this Mar 19, 2023
@alexandrevryghem alexandrevryghem added quick win Pull request is small in size & should be easy to review and/or merge configuration Related to out-of-the-box configuration labels Mar 19, 2023
@alexandrevryghem alexandrevryghem force-pushed the added-vtt-to-default-supported-bitstream-types branch from 96562ae to f221de0 Compare March 19, 2023 23:31
@tdonohue tdonohue added this to the 7.6 milestone Mar 20, 2023
@tdonohue tdonohue added the 1 APPROVAL pull request only requires a single approval to merge. label Mar 20, 2023
@alexandrevryghem alexandrevryghem force-pushed the added-vtt-to-default-supported-bitstream-types branch from f221de0 to 29550a8 Compare March 20, 2023 20:25
@github-actions github-actions bot added the merge conflict PR has a merge conflict that needs resolution label Apr 3, 2023
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

Hi @alexandrevryghem,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@alexandrevryghem alexandrevryghem force-pushed the added-vtt-to-default-supported-bitstream-types branch from 29550a8 to 0e0962e Compare April 3, 2023 21:56
@github-actions github-actions bot removed the merge conflict PR has a merge conflict that needs resolution label Apr 3, 2023
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @alexandrevryghem ! This looks good to me.

@tdonohue tdonohue merged commit 5d14b23 into DSpace:main Apr 4, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge. configuration Related to out-of-the-box configuration quick win Pull request is small in size & should be easy to review and/or merge
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants