Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable entity type to submission form mapping by default #9004

Merged
merged 1 commit into from Aug 3, 2023

Conversation

tdonohue
Copy link
Member

@tdonohue tdonohue commented Aug 2, 2023

References

Description

In DSpace 7.6, we added a commented out configuration to item-submission.xml which enables mapping a Collection to a submission form definition based on the Collection's entity type field.

This PR simply uncomments that configuration by default so that it exists by default in all sites. I've already verified uncommenting this configuration has no impact on sites which have entities disabled (they simply ignore this configuration). But, it's a huge benefit to sites that have Entities enabled as it can ensure their Collections can be easily mapped to a submission form.

It's also a big benefit to the upcoming Demo site, as it will need this configuration for the same reason as other sites where Entities are enabled.

@tdonohue tdonohue added configuration Related to out-of-the-box configuration 1 APPROVAL pull request only requires a single approval to merge. port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Aug 2, 2023
@tdonohue tdonohue added this to the 8.0 milestone Aug 2, 2023
@tdonohue tdonohue self-assigned this Aug 2, 2023
@tdonohue tdonohue modified the milestone: 8.0 Aug 2, 2023
@tdonohue
Copy link
Member Author

tdonohue commented Aug 3, 2023

This was discussed in today's DevMtg and no objections were raised. Merging this, as this benefits our new demo site (as it allows the demo site to use Entities submission forms without having to manually customize this file). It also benefits other sites using Entities for the same reason. As noted above, this was tested on a site with Entities disabled and had no negative impact.

@tdonohue tdonohue merged commit 1011708 into DSpace:main Aug 3, 2023
15 checks passed
@tdonohue tdonohue deleted the enable_entity_mapping branch August 3, 2023 16:22
@dspace-bot
Copy link

Successfully created backport PR for dspace-7_x:

@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge. configuration Related to out-of-the-box configuration
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants