Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication Method related special groups are put in claim set even if a different authentication method is used #9130

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

LucaGiamminonni
Copy link
Contributor

@LucaGiamminonni LucaGiamminonni commented Oct 18, 2023

References

Description

With these changes the system is able to distinguish when special groups are to be put in context, for example only when a specific authentication method is used.

Instructions for Reviewers

Steps to reproduce the behavior:

  • Enable Shibboleth authentication
  • Configure a special group to be put in context during Shibboleth Authentication flow
  • Login via Password Authentication and go to "Profile" Page
  • Authorization special groups you belong to will not list the special group set at point 2

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
  • My PR passes Checkstyle validation based on the Code Style Guide.
  • My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
  • My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
  • If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge. authentication: general general authentication issues or new features port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Oct 19, 2023
@tdonohue tdonohue self-requested a review October 19, 2023 14:53
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @LucaGiamminonni ! Finally got to testing/reviewing this today. This fixes the bug as described. Also fixes #9074 (which appears to be a duplicate ticket describing the same bug)

@tdonohue tdonohue added the authentication: Shibboleth Related to authentication via Shibboleth label Nov 9, 2023
@tdonohue tdonohue merged commit 5083640 into DSpace:main Nov 9, 2023
13 checks passed
@dspace-bot
Copy link

@tdonohue tdonohue added this to the 8.0 milestone Nov 9, 2023
@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge. authentication: general general authentication issues or new features authentication: Shibboleth Related to authentication via Shibboleth bug
Projects
Status: ✅ Done
3 participants