Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of page url in FeedbackRestRepository #9289

Merged
merged 2 commits into from Apr 30, 2024

Conversation

saschaszott
Copy link
Contributor

References

This PR fixes #9288

Description

This PR adds a simple validation of the page url.

@saschaszott
Copy link
Contributor Author

We should add a test case in FeedbackRestRepositoryIT to check that the generated email does not contain manipulated page urls. Unfortunately, the DS backend unit tests do not run on my local dev environment ;(

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge. port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Jan 26, 2024
@tdonohue tdonohue self-requested a review April 11, 2024 14:51
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @saschaszott ! I've tested this today. I was able to verify/reproduce the bug, and this fixes it.

@tdonohue tdonohue added this to the 8.0 milestone Apr 30, 2024
@tdonohue tdonohue merged commit 2345ee4 into DSpace:main Apr 30, 2024
22 checks passed
@dspace-bot
Copy link

Successfully created backport PR for dspace-7_x:

@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge. bug
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

missing validation of page url in FeedbackRestRepository
3 participants