Fix Docker image build issues for new versions of Docker (25.0.2) and Docker Compose (2.24.3)

[tdonohue]

References

• Fixes Docker images fail to build with new versions of Docker (25.0.2) and Docker Compose (2.24.3) #9302

Description

Fixes the two errors described in #9302

1. The networks error was fixed by ensuring all docker-compose files reference the dspacenet (external) network that is created in the main [src]/docker-compose.yml. This is based on the documentation here: https://docs.docker.com/compose/networking/#use-a-pre-existing-network
2. The dspacesolr build error was fixed by using a new additional_contexts option available since docker compose version 2.17.0. This allows our main [src]/docker-compose.yml script to pass the path of the Solr configs to dspace/src/main/docker/dspace-solr/Dockerfile so that Dockerfile can locate the configurations necessary to build dspacesolr.

Instructions for Reviewers

• Before this is merged we obviously must ensure it also works for GitHub actions/CI. This will be a good test that older versions of Docker / Docker Compose can still build these images as GitHub actions is currently using Docker v24.07 and Docker Compose v2.21.0

I'm still testing that all our Compose files now build (including those that are not used as frequently like IIIF and Shib).

Because this is a blocker for my ability to test 8.0 PRs (as I cannot get main to build), I plan to merge this immediately if everything is successful. Afterwards, I will also investigate whether this needs to be ported to dspace-angular (I suspect it does) and possibly also the dspace-7_x branches of both projects.

[tdonohue]

NOTE: After discussion with @wwelling on Slack, I've realized that the dspacesolr build error might have been caused by a Windows bug in "docker compose": moby/moby#47231

However, I still feel the changes in this PR to use additional_contexts (to pass in the path of the Solr configs) seems like it may be more stable for the long term. That way the path to these configs can be passed in, rather than "assumed" by the Dockerfile.

[tdonohue]

Fully tested locally and alongside fixes to frontend in DSpace/dspace-angular#2791 This appears to fix the issue and appears to be compatible with older versions of Docker (as used in GitHub Actions)

[dspace-bot]

Backport failed for dspace-7_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-7_x
git worktree add -d .worktree/backport-9303-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-9303-to-dspace-7_x
git switch --create backport-9303-to-dspace-7_x
git cherry-pick -x a84d2440a77dd8156b06a6a3d4135fb045bd6f5a 5f9565e267a18742e4192c29d17bcb6f9eaa1245 8fb4dd59549b004a9a7c7cbfedb75f4f5ca2f410

[tdonohue]

Ported manually to dspace-7_x in #9304