adding Unicode filtering for sorts #9432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulo-graca
added
the
1 APPROVAL
tdonohue
added
component: Discovery
tdonohue
approved these changes
May 8, 2024
There was a problem hiding this comment.
👍 Thanks @paulo-graca ! Apologies it took so long to get to this PR. But, I've verified this fixes the bug. Porting this also to main.
|
Successfully created backport PR for |
tdonohue
removed
the
port to main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
This PR adds a new solr filter for lowerCaseSort that applies Unicode normalization
Instructions for Reviewers
To test it, you need to add a new community with diacritics like
ÂBC - Testand do a full index:/dspace/bin/dspace index-discovery -bYour repository should have some communities, starting with different letters.
The community
ÂBC - Testshould appear on the top, or near the other AA