Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dc.type required #9440

Merged
merged 1 commit into from Apr 4, 2024
Merged

Conversation

pnbecker
Copy link
Member

fixes #9357

Description

Make dc.type required as discussed in dev meeting and in #9357

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
  • My PR passes Checkstyle validation based on the Code Style Guide.
  • My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
  • My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
  • If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@pnbecker pnbecker requested a review from tdonohue March 28, 2024 15:46
@pnbecker pnbecker self-assigned this Mar 28, 2024
@pnbecker pnbecker added configuration Related to out-of-the-box configuration component: submission Related to configurable submission system 1 APPROVAL pull request only requires a single approval to merge. labels Mar 28, 2024
@tdonohue tdonohue added this to the 8.0 milestone Mar 28, 2024
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @pnbecker ! This looks good to me and it can be merged once the backend upgrades are completed in #9321

I've also looked at the failing IT and I can verify this test was refactored in #9321 because I found it was "flakey". So, this failing IT is unrelated to this PR, and I believe it will be "fixed" once #9321 is merged.

@tdonohue tdonohue merged commit adee7f8 into DSpace:main Apr 4, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge. component: submission Related to configurable submission system configuration Related to out-of-the-box configuration
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Should dc.type be required by default?
2 participants