Refactor SubmissionConfigReader to use a map for the item process configurations based on entityType

[toniprieto]

References

• Fixes Default form is displayed for a Publication when I specified a proper submission-name #9402
• Fixes When Solr cannot be found on startup, an odd NullPointerException may appear in logs *after* the important SolrServerException #9217 (The strange NullPointerException will no longer occur. Now you get a clear error message that Solr is unavailable, e.g. Failed to contact Solr at http://dspacesolr:8983/solr/search : IOException occurred when talking to server at: http://dspacesolr:8983/solr/search)
• Related to Create Collection takes 30-45 seconds & sometimes times out dspace-angular#2914
• Port to 7x: [Port dspace-7_x] Refactor SubmissionConfigReader to use a map for the item process configurations based on entityType #9487

Description

This PR implements the changes described in this comment to utilize a map for returning the item process submission form configured for collections with a specific entityType. The implementation follows a similar approach to #9259

Instructions for Reviewers

List of changes in this PR:

• Refactor SubmissionConfigReader to use a new map for entityType-configured submission forms
• Add a new test to ensure that entityType-configured submission forms work correctly and take precedence over community-based configurations.
• Remove from default configuration the submissionconfig consumer used to reload the submission configuration after creating/modifying a collection. With the proposed changes, this reload should not be necessary. This change could be undone if it is useful for other use cases.

Test that the entityType configurations are working properly after creating o editing the entityType of a collection and that the issue #9402 is also resolved.

Checklist

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
• My PR passes Checkstyle validation based on the Code Style Guide.
• My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
• My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
• If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
• If my PR includes new configurations, I've provided basic technical documentation in the PR itself.

[paulo-graca]

Thank you @toniprieto for this contribution! With this PR, we don't need to reload (can also be configured to do it so) submission configuration every time we change a collection. It's a much better implementation. It also ensures that if we specify an handle, it will be given priority to that configuration.
I just have one request, if you within this PR, could remove unused collectionService code

• findAllCollectionsByEntityType.

[paulo-graca]

👍 this will ensure that if an handle is specified, then it will be firstly returned

[toniprieto]

@paulo-graca @tdonohue Thank you for the reviews, the feedback has been addressed.

Two extra comments:

• I think this PR is also a fix for When Solr cannot be found on startup, an odd NullPointerException may appear in logs *after* the important SolrServerException #9217 (With this change, Solr is no longer used during the initialization of SubmissionConfigService, which prevents the NullPointer mentioned in the issue)
• The documentation still mentions twice that it is necessary to restart Tomcat after creating a collection with an entity. I think that these two sentences can be removed: https://wiki.lyrasis.org/display/DSDOC8x/Submission+User+Interface#SubmissionUserInterface-AssigningacustomSubmissionProcesstoaCollection

[paulo-graca]

Thank you @toniprieto! All changes are looking perfect to me. It's a +1 on my behalf. I will try to test it in our on-premises setup.

[vins01-4science]

Thank you @toniprieto,

@tdonohue: I checked that this PR is solving the issue I was figuring out by starting the backend with the server-boot configuration (#9505 (comment), #9476).
So if everything looks good for @tdonohue , I think that we can merge this PR in order to solve both issues 🚀 !

[tdonohue]

Thanks for the note @vins01-4science ! I'll test this today as well and, assuming it works for me, I'll get it merged immediately. I'm very glad to hear this refactor should help solve issues that we were having in other PRs!

[tdonohue]

👍 Thanks @toniprieto ! This looks great. Verified this fixes #9402. I've also verified it fixes #9217 as well (which is likely why this PR helps fix issues with other PRs, as I think #9217 was the root cause in those scenarios).

Merging immediately as this looks great and provides major benefits the the startup process as well as fixes SubmissionConfigReader bugs.

[tdonohue]

I've also updated the Submission Docs to remove mentions of having to restart Tomcat whenever a new Entity Collection is created (as this fixes that bug): https://wiki.lyrasis.org/display/DSDOC8x/Submission+User+Interface#SubmissionUserInterface-AssigningacustomSubmissionProcesstoaCollection