Fixed too long classpath bug in test_databaseFixed classpath issue in test_database target #9539
+18
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
In the original state of the
test_database
target inbuild.xml
, the classpath built within the task becomes too long to be properly handled by the<java>
task that follows, which causes failure of any task that includestest_database
. I fixed the task so that the classpath is stored in an alias that is then used in the<javac>
task, which doesn't fail anymore.Instructions for Reviewers
After building the project using Maven, run
fresh_install
(or any task that hastest_database
in its transitive dependencies) in/dspace/target/dspace-installer/build.xml
.List of changes in this PR:
test_database
target in/dspace/target/dspace-installer/build.xml
.Please note that I am not sure whether this behaviour will be reproducible in all environments. I work in a Windows 10-based environment.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
Please note that unchecked entries below are not applicable to non-Java files.
pom.xml
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.