Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed too long classpath bug in test_databaseFixed classpath issue in test_database target #9539

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeffmorin
Copy link
Contributor

References

Description

In the original state of the test_database target in build.xml, the classpath built within the task becomes too long to be properly handled by the <java> task that follows, which causes failure of any task that includes test_database. I fixed the task so that the classpath is stored in an alias that is then used in the <javac> task, which doesn't fail anymore.

Instructions for Reviewers

After building the project using Maven, run fresh_install (or any task that has test_database in its transitive dependencies) in /dspace/target/dspace-installer/build.xml.

List of changes in this PR:

  • Fixed the test_database target in /dspace/target/dspace-installer/build.xml.

Please note that I am not sure whether this behaviour will be reproducible in all environments. I work in a Windows 10-based environment.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

Please note that unchecked entries below are not applicable to non-Java files.

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
  • My PR passes Checkstyle validation based on the Code Style Guide.
  • My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
  • My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
  • If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge. port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels May 3, 2024
@tdonohue tdonohue self-requested a review May 23, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge. bug port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release
Projects
Status: 👀 Under Review
Development

Successfully merging this pull request may close these issues.

build.xml fails due to a too long classpath error
2 participants