Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSpace#1306(open ticket for the frontend) - Implemented new metadata in the dspace schema to store … #9550

Closed

Conversation

DanGastardelli
Copy link

@DanGastardelli DanGastardelli commented May 7, 2024

DSpace/dspace-angular#1306 - Implemented new metadata in the dspace schema to store thumbnail descriptions of collections and communities

References

DSpace/dspace-angular#1306
This change was targeted at DSpace/dspace-angular#1306 which now allows storing in a "dspace" schema metadata a detailed description of collection and community logo thumbnail images (also recognized by screen readers). This change is linked to another made in the frontend with the same ticket name.

Description

The "dspace.thumbnail.description" metadata was added to be able to store thumbnail descriptions

Instructions for reviewers

Use a new database and use the "dspace database migrate" command in the "bin" folder of the installed DSpace or perform a new installation of DSpace with this change applied.

List of changes in this PR:
*The "dspace.thumbnail.description" was created for the schema "dspace" in the file "dspace/config/registries/dspace-types.xml"

Include guidance on how to test or review your PR.

When installing DSpace, simply check whether the "dspace.thumbnail.description" metadata was created correctly on the DSpace metadata registration page, in the "dspace" schema.

@DanGastardelli DanGastardelli changed the title DSpace#1306 - Implemented new metadata in the dspace schema to store … DSpace-1306 - Implemented new metadata in the dspace schema to store … May 7, 2024
@DanGastardelli DanGastardelli changed the title DSpace-1306 - Implemented new metadata in the dspace schema to store … DSpace#1306(DSpace/dspace-angular/issues/1306) - Implemented new metadata in the dspace schema to store … May 7, 2024
@DanGastardelli DanGastardelli changed the title DSpace#1306(DSpace/dspace-angular/issues/1306) - Implemented new metadata in the dspace schema to store … DSpace#1306(open ticket for the frontend) - Implemented new metadata in the dspace schema to store … May 7, 2024
@tdonohue tdonohue changed the base branch from dspace-8.0-testathon to main May 8, 2024 14:17
@tdonohue
Copy link
Member

tdonohue commented May 8, 2024

@DanGastardelli : Same here, please rebase this on main as all PRs should be against main (and not the temporary dspace-8.0-testathon branch, which was only used for Testathon).

@tdonohue tdonohue added improvement 1 APPROVAL pull request only requires a single approval to merge. labels May 8, 2024
@tdonohue tdonohue added this to the 8.0 milestone May 8, 2024
@DanGastardelli
Copy link
Author

@tdonohue, sorry for the inconvenience, but it seems that you had already changed this PR to main correct?

Looking forward to your feedback!

@DanGastardelli DanGastardelli reopened this May 8, 2024
@tdonohue
Copy link
Member

tdonohue commented May 8, 2024

@DanGastardelli : The same issue exists with this PR. While I did change it to main, the code on your branch is outdated, so it's showing 5 commits in this PR (some of which are unrelated). You'll need to rebase this PR on main to remove the unrelated commits. See comment on other PR: DSpace/dspace-angular#3018 (comment)

@DanGastardelli
Copy link
Author

@tdonohue, I understand, once again I apologize for the inconvenience. This will be adjusted. Thank you very much for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge. improvement
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants