Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken ITs after merger of #9485 #9577

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

tdonohue
Copy link
Member

References

Description

Fixes several broken tests in RelationshipDeleteRestRepositoryIT after the merger of #9485. Because that PR changed the metadata field for isPersonOfProject relationship from dc.contributor.author to project.investigator, several ITs broke. This fixes those ITs.

The correct metadata field for this relationship is project.investigator as specified in our submission-forms.xml: https://github.com/DSpace/DSpace/blob/main/dspace/config/submission-forms.xml#L517-L531

Instructions for Reviewers

  • If ITs all pass this will be merged immediately. Currently ITs are broken on main

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge. testing framework Related specifically to Unit or Integration Tests port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels May 13, 2024
@tdonohue tdonohue added this to the 8.0 milestone May 13, 2024
@tdonohue tdonohue merged commit 8a3943d into DSpace:main May 13, 2024
22 checks passed
@dspace-bot
Copy link

Successfully created backport PR for dspace-7_x:

@tdonohue tdonohue deleted the IT_fixes branch May 13, 2024 22:23
@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge. bug testing framework Related specifically to Unit or Integration Tests
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants