Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve interoperability: replace hard-coded slash by File.separator #9580

Merged
merged 1 commit into from
May 15, 2024

Conversation

saschaszott
Copy link
Contributor

Description

This PR replaces hard-coded slashes in directory paths.

@tdonohue tdonohue added code task Code cleanup task 1 APPROVAL pull request only requires a single approval to merge. port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels May 14, 2024
@tdonohue tdonohue added this to the 8.0 milestone May 14, 2024
@mwoodiupui
Copy link
Member

I agree with this improvement, but also have a suggestion for the future: I've taken to using Paths instead of Strings for filesystem paths wherever feasible, and then I don't have to deal with separator characters at all.

Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @saschaszott ! This looks good to me too.

@tdonohue tdonohue merged commit 50aaec1 into DSpace:main May 15, 2024
22 checks passed
@dspace-bot
Copy link

Successfully created backport PR for dspace-7_x:

@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge. code task Code cleanup task
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants