Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a short lived token using GET to deal with CSRF in Angular #159

Merged
merged 1 commit into from Apr 1, 2021

Conversation

benbosman
Copy link
Member

This is related to DSpace/dspace-angular#1004 (comment)

It adds the GET endpoint as an alternative, which is only available from the trusted IP

@benbosman benbosman added this to Needs Reviewers Assigned in DSpace 7 Beta 5 via automation Apr 1, 2021
@benbosman benbosman added this to the 7.0beta5 milestone Apr 1, 2021
@benbosman benbosman requested a review from tdonohue April 1, 2021 15:01
@benbosman benbosman self-assigned this Apr 1, 2021
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me. Thanks for this @benbosman !

DSpace 7 Beta 5 automation moved this from Needs Reviewers Assigned to Reviewer Approved Apr 1, 2021
@tdonohue tdonohue merged commit b30f528 into DSpace:main Apr 1, 2021
DSpace 7 Beta 5 automation moved this from Reviewer Approved to Done Apr 1, 2021
DSpace 7 Beta 5 automation moved this from Done to Reviewer Approved Apr 15, 2021
DSpace 7 Beta 5 automation moved this from Reviewer Approved to Done Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants