101353: Fix VocabularyTreeview onSelect being called twice

DSpace · Apr 26, 2023 · bb242d9 · bb242d9
1 parent 14b053b
commit bb242d9
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/app/shared/form/vocabulary-treeview/vocabulary-treeview.component.html b/src/app/shared/form/vocabulary-treeview/vocabulary-treeview.component.html
@@ -33,7 +33,9 @@ <h4 *ngIf="!(loading | async) && dataSource.data.length === 0" class="text-cente
                 container="body"
                 (click)="onSelect(node.item)">
           <span *ngIf="multiSelect" class="form-check">
-            <input class="form-check-input" type="checkbox" id="leaf-node-checkbox_{{node.item.id}}" [checked]="node.isSelected">
+            <!-- checkbox (click) needs to be stopped, to prevent that button (click) gets called twice -->
+            <input class="form-check-input" type="checkbox" id="leaf-node-checkbox_{{node.item.id}}"
+                   [checked]="node.isSelected" (click)="$event.stopPropagation()">
             <label class="form-check-label" for="leaf-node-checkbox_{{node.item.id}}">{{node.item.display}}</label>
           </span>
           <span *ngIf="!multiSelect">{{node.item.display}}</span>
@@ -57,7 +59,9 @@ <h4 *ngIf="!(loading | async) && dataSource.data.length === 0" class="text-cente
                 container="body"
                 (click)="onSelect(node.item)">
           <span *ngIf="multiSelect" class="form-check">
-            <input class="form-check-input" type="checkbox" id="expandable-node-checkbox_{{node.item.id}}" [checked]="node.isSelected">
+            <!-- checkbox (click) needs to be stopped, to prevent that button (click) gets called twice -->
+            <input class="form-check-input" type="checkbox" id="expandable-node-checkbox_{{node.item.id}}"
+                   [checked]="node.isSelected" (click)="$event.stopPropagation()">
             <label class="form-check-label" for="expandable-node-checkbox_{{node.item.id}}">{{node.item.display}}</label>
           </span>
           <span *ngIf="!multiSelect">{{node.item.display}}</span>