Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages are loading twice #1357

Closed
davidatmire opened this issue Oct 14, 2021 · 5 comments · Fixed by #1627
Closed

Pages are loading twice #1357

davidatmire opened this issue Oct 14, 2021 · 5 comments · Fixed by #1627
Assignees
Labels
bug e/30 high priority performance / caching Related to performance, caching or embedded objects
Milestone

Comments

@davidatmire
Copy link
Contributor

Describe the bug
When you open some DSpace 7 pages, they appear to load twice, which is confusing for the user.

I have been able to reproduce this at least on homepage / collection page / item page even if it doesn't happen systematically.
This behaviour can be experienced on demo7 : https://demo7.dspace.org/home

To Reproduce
Steps to reproduce the behavior:

  1. Open https://demo7.dspace.org/home (or other collection / item pages) in a new browser tab
  2. The page is first displayed for a short time
  3. Then a blank page appears for a short time too
  4. Finally the page reappears and is displayed properly

Expected behavior
Pages should only be loading once

Related work
@artlowel has already identified that

  • the first page displayed is the server side rendered version
  • then JS kicks in and it starts loading
  • then you see the client side rendered version
@davidatmire davidatmire added bug needs triage New issue needs triage and/or scheduling labels Oct 14, 2021
@MarisArins
Copy link

I have not seen it in particular, but can this be somehow caused by UI language change ? That is causing UI reload.

@tdonohue
Copy link
Member

tdonohue commented Nov 3, 2021

@davidatmire and @artlowel : I've seen this behavior. I admit, I had assumed this was somewhat "expected" on the first page load, because the page starts as server-side rendered and then is re-rendered by the client. That said, I'd love to see this fixed. Is there a recommendation/suggestion for how this would be fixed?

For now, moving to 7.2 board with high priority and estimate TBD.

(@MarisArins : This happens on first page load (first time visiting the site in your browser), and is definitely not caused by a UI language change. The UI language change does result in a similar reload and it may be impacted by this same issue noted in this ticket.)

@tdonohue tdonohue added Estimate TBD high priority performance / caching Related to performance, caching or embedded objects and removed needs triage New issue needs triage and/or scheduling labels Nov 3, 2021
@tdonohue
Copy link
Member

tdonohue commented Nov 8, 2021

Duplicated (with video demo) in #1391

@tdonohue
Copy link
Member

tdonohue commented Nov 10, 2021

@artlowel : Per today's meeting discussion, assigning this to you / your team & adding your 30hr estimate. Feel free to start implementation

@tdonohue tdonohue added e/4 Estimate in hours and removed Estimate TBD labels Nov 10, 2021
@tdonohue tdonohue added this to the 7.2 milestone Nov 10, 2021
@tdonohue tdonohue added e/30 and removed e/4 Estimate in hours labels Nov 10, 2021
@tdonohue
Copy link
Member

Corrected estimate to 30hrs. I mixed this up with a different ticket.

@tdonohue tdonohue removed this from the 7.2 milestone Jan 13, 2022
@ybnd ybnd mentioned this issue Apr 28, 2022
6 tasks
@tdonohue tdonohue added this to the 7.3 milestone May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug e/30 high priority performance / caching Related to performance, caching or embedded objects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants