Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media viewer controls rendered behind DSpace header #2341

Closed
ybnd opened this issue Jun 26, 2023 · 7 comments · Fixed by #2594
Closed

Media viewer controls rendered behind DSpace header #2341

ybnd opened this issue Jun 26, 2023 · 7 comments · Fixed by #2594
Assignees
Labels
bug claimed: 4Science 4Science team is working on this issue & will contribute back component: Item (Archived) Item display or editing high priority usability
Milestone

Comments

@ybnd
Copy link
Member

ybnd commented Jun 26, 2023

Describe the bug
The preview of ngx-gallery is rendered behind the DSpace header, which obscures its controls, including the "Close" button. Because of this, the preview can only be closed by

  • pressing Esc (which is likely not obvious to users)
  • refreshing the page
  • navigating to another page

To Reproduce
Steps to reproduce the behavior:

  1. Open (or create) an Item with multiple images in the ORIGINAL Bundle
  2. Click on the media viewer placeholder to open th preview

Expected behavior
The preview should be drawn over top of the header.

Solutions
Can be solved here by either

  • not specifying a z-index (note that the z-index of ngx-gallery is already higher than the one we set here!)
  • or specifying position: static

However, these changes are incompatible with mobile view (see #2220)

@ybnd ybnd added bug usability needs triage New issue needs triage and/or scheduling component: Item (Archived) Item display or editing labels Jun 26, 2023
@tdonohue tdonohue added help wanted Needs a volunteer to claim to move forward high priority good first issue This is a smaller ticket/bug that may be easier for new contributors and removed needs triage New issue needs triage and/or scheduling labels Jun 30, 2023
@HamzaFarooqArif
Copy link

I want to work on it. please assign it to me

@tdonohue
Copy link
Member

Thanks again @HamzaFarooqArif for volunteering!

@tdonohue tdonohue removed help wanted Needs a volunteer to claim to move forward good first issue This is a smaller ticket/bug that may be easier for new contributors labels Jul 20, 2023
@HamzaFarooqArif
Copy link

I apologize that I'll not be able to continue working on it. I'm unassigning me from this issue

@HamzaFarooqArif HamzaFarooqArif removed their assignment Jul 21, 2023
@tdonohue tdonohue added help wanted Needs a volunteer to claim to move forward good first issue This is a smaller ticket/bug that may be easier for new contributors labels Jul 21, 2023
@tdonohue
Copy link
Member

tdonohue commented Aug 9, 2023

Additional details from duplicate ticket #2429 created by @Sondissimo :

Describe the bug
When we select an item, if we open the bitstream to visualize it, we encounter a strange behaviour regarding the top navbar.
Version: 7.6

To Reproduce
Steps to reproduce the behavior:

  1. When we visualize an item bitstream the navbar is not correctly rendering
    image

Expected behavior
The navbar shouldnt be visible when inspecting bitstreams

Related work
DSpace/DSpace#9022

@tdonohue
Copy link
Member

tdonohue commented Aug 9, 2023

Assigning to @Sondissimo who volunteered on behalf of 4Science.

@tdonohue tdonohue added claimed: 4Science 4Science team is working on this issue & will contribute back and removed help wanted Needs a volunteer to claim to move forward good first issue This is a smaller ticket/bug that may be easier for new contributors labels Aug 9, 2023
@davide-negretti davide-negretti self-assigned this Oct 31, 2023
@davide-negretti
Copy link
Contributor

I'm now working on this one in place of @Sondissimo

@davide-negretti
Copy link
Contributor

I opened a PR: #2594

@tdonohue tdonohue added this to the 7.6.1 milestone Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug claimed: 4Science 4Science team is working on this issue & will contribute back component: Item (Archived) Item display or editing high priority usability
Projects
Development

Successfully merging a pull request may close this issue.

4 participants