Fixed mobile navbar not expanding & use same css variable for all header icons#2220
Merged
tdonohue merged 2 commits intoDSpace:mainfrom May 9, 2023
Conversation
c420cf2 to
c042a5c
Compare
tdonohue
approved these changes
May 9, 2023
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @alexandrevryghem ! I was able to reproduce the mobile navbar bug on main. I've verified this fixes the bug (for both themes) and verified the CSS variables for header icons work (again for both themes).
4science-it
pushed a commit
to 4Science/dspace-angular
that referenced
this pull request
Sep 9, 2024
[DSC-1902] enable edit and new menu sections for community and collections admin Approved-by: Vincenzo Mecca
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently the mobile navbar does not open on the home page and on other pages like the item page the navbar is not being shown correctly for both the
dspaceand thecustomtheme.This PR also makes it easier to customise the color and the hover color from the header icons by using the same variable for all of them (using the css variables
--ds-header-icon-color&--ds-header-icon-color-hover).Instructions for Reviewers
List of changes in this PR:
HeaderNavbarWrapperComponent: applied the--ds-nav-z-indexon the wrapper--ds-header-icon-color&--ds-header-icon-color-hoveron every header iconGuidance for how to test and review this PR:
customtheme insrc/themes/eager-themes.module.tsdspaceand thecustomtheme check the following:_theme_css_variable_overrides.scss:Checklist
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.