Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update folder structure based on latest Style Guide #327

Closed
tdonohue opened this issue Nov 14, 2018 · 2 comments · Fixed by #1278
Closed

Update folder structure based on latest Style Guide #327

tdonohue opened this issue Nov 14, 2018 · 2 comments · Fixed by #1278
Assignees
Labels
bug code task Difficulty: Low Estimated at less than 8 hours
Milestone

Comments

@tdonohue
Copy link
Member

tdonohue commented Nov 14, 2018

Our current folder structure includes a lot of module paths that are prefixed with +.
See: https://github.com/DSpace/dspace-angular/tree/master/src/app

This naming pattern used to be the recommended one for lazy loaded folders, see: https://github.com/angular/angular.io/blob/b21c90c358129efdd55da897fb7756d44f3b65ae/public/docs/ts/latest/guide/style-guide.jade#L1252

However, in the latest version of the style guide, that recommendation no longer exists: https://angular.io/guide/styleguide#lazy-loaded-folders

We should consider simply renaming these folders to no longer include the + prefix, as that's now a non-standard folder name.

@tdonohue tdonohue added bug Difficulty: Low Estimated at less than 8 hours labels Sep 18, 2019
@tdonohue
Copy link
Member Author

I ran into this again. Just noting here that the Angular team says to no longer prefix folders with +.
angular/angular.io#2944

Therefore, we should rename all these folders, as the + has no meaning, and looks confusing to new devs / users.

@tdonohue
Copy link
Member Author

@artlowel : Realized we have an old ticket about renaming the "+" directories. Assigning to you to see if you or your team could quickly do this prior to 7.0. If you run into issues though or complications, let me know & we can reschedule this for just after 7.0.

@tdonohue tdonohue added this to To Do in DSpace 7.0 (final) release via automation Jul 23, 2021
@tdonohue tdonohue moved this from To Do to In Progress in DSpace 7.0 (final) release Jul 23, 2021
@tdonohue tdonohue added this to the 7.0 milestone Jul 23, 2021
DSpace 7.0 (final) release automation moved this from In Progress to Done Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug code task Difficulty: Low Estimated at less than 8 hours
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants