Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update folder structure based on style guide #1278

Merged
merged 3 commits into from
Jul 23, 2021

Conversation

artlowel
Copy link
Member

@artlowel artlowel commented Jul 23, 2021

References

Description

This PR removes the + from all folder names. It was used to indicate lazily loaded modules, but since that's the default now it is no longer recommended in the style guide.

Instructions for Reviewers

The biggest thing to verify is that I haven't accidentally removed a + where I shouldn't have, e.g. in a string that doesn't refer to a path.

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR doesn't introduce circular dependencies
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

@artlowel artlowel added this to the 7.0 milestone Jul 23, 2021
@artlowel artlowel requested a review from tdonohue July 23, 2021 15:28
@artlowel artlowel self-assigned this Jul 23, 2021
@artlowel artlowel added this to Needs Reviewers Assigned in DSpace 7.0 (final) release via automation Jul 23, 2021
@tdonohue tdonohue self-requested a review July 23, 2021 16:24
@tdonohue tdonohue added 1 APPROVAL pull request only requires a single approval to merge code task labels Jul 23, 2021
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great now, @artlowel ! Thanks again. I've run this locally and done a quick test of most pages of the site (login/logout, clicked around in admin tools, edited every type of object, completed submissin, etc). As we'd expect, everything appears to be working. As soon as GitHub CI finishes it's tests/approval, I'll get this merged.

DSpace 7.0 (final) release automation moved this from Needs Reviewers Assigned to Reviewer Approved Jul 23, 2021
@tdonohue tdonohue merged commit e9a0399 into DSpace:main Jul 23, 2021
DSpace 7.0 (final) release automation moved this from Reviewer Approved to Done Jul 23, 2021
@tdonohue tdonohue mentioned this pull request Jul 23, 2021
@artlowel artlowel deleted the remove-plus-from-folders branch July 26, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge code task
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Update folder structure based on latest Style Guide
2 participants