-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update folder structure based on style guide #1278
Conversation
src/app/browse-by/browse-by-switcher/themed-browse-by-switcher.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks great now, @artlowel ! Thanks again. I've run this locally and done a quick test of most pages of the site (login/logout, clicked around in admin tools, edited every type of object, completed submissin, etc). As we'd expect, everything appears to be working. As soon as GitHub CI finishes it's tests/approval, I'll get this merged.
References
Description
This PR removes the
+
from all folder names. It was used to indicate lazily loaded modules, but since that's the default now it is no longer recommended in the style guide.Instructions for Reviewers
The biggest thing to verify is that I haven't accidentally removed a + where I shouldn't have, e.g. in a string that doesn't refer to a path.
Checklist
yarn run lint
package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.