Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BrowseBy list are statically configured #852

Closed
LucaGiamminonni opened this issue Sep 1, 2020 · 1 comment · Fixed by #1468
Closed

BrowseBy list are statically configured #852

LucaGiamminonni opened this issue Sep 1, 2020 · 1 comment · Fixed by #1468

Comments

@LucaGiamminonni
Copy link
Contributor

Describe the bug
The browseBy list present in the community and collection pages are not dynamically discovered using the api/discover/browses endpoint but are read from a static configuration present within the environment. In detail, the available browseBy are read from the browseBy.types property of the environment.

To Reproduce
Steps to reproduce the behavior:

  1. Go under the Communities & Collections section
  2. Select a community or a collection
  3. Verify that the browseBy shown are only those present in the environment.browseBy.types property and that no calls to a REST endpoint are made to obtain them

Expected behavior
The browseBy list present in the community and collection pages should be dynamically obtained using the api/discover/browses endpoint. This implies that the browseBy.types property of the environment must be removed and where used it must be replaced with the configurations provided by the REST interface.
Since in the browseBy.types list is indicated the type of browse (date, title, metadata), it is necessary to modify the existing endpoint api/discover/browses to add this information. As a possible solution to extend the current REST endpoint I propose to:

  • add the sorting type to the objects belonging to the sortOptions property
  • add a defaultSort property that matches the name of the default sort for that browse; in this way, using this property it will be possible to obtain the type of browse by searching for the type of sort of the one configured as default.
@LucaGiamminonni LucaGiamminonni added bug e/24 Estimate in hours needs triage New issue needs triage and/or scheduling labels Sep 1, 2020
@LucaGiamminonni LucaGiamminonni changed the title BrowseBy list are statically configured angular side BrowseBy list are statically configured Sep 1, 2020
@tdonohue tdonohue removed the needs triage New issue needs triage and/or scheduling label Sep 8, 2020
@tdonohue tdonohue added this to To Do in DSpace 7.1 release via automation Sep 8, 2020
@tdonohue tdonohue added this to the 7.1 milestone Sep 8, 2020
@tdonohue
Copy link
Member

tdonohue commented Sep 8, 2020

I'm tentatively scheduling this for 7.1. For the 7.0 release, at this time, I don't think it matters too much if the BrowseBy types need to be configured/ordered in your environment.common.ts here: https://github.com/DSpace/dspace-angular/blob/main/src/environments/environment.common.ts#L172

Longer term, you are right, it'd be nice if this was setup automatically based on the REST API.

@tdonohue tdonohue removed this from To Do in DSpace 7.1 release Jul 13, 2021
@tdonohue tdonohue added this to To Do in DSpace 7.x Tier 2: Medium High Priority via automation Jul 13, 2021
@tdonohue tdonohue removed this from the 7.1 milestone Jul 13, 2021
@tdonohue tdonohue added this to To Do in DSpace 7.2 release via automation Dec 2, 2021
@tdonohue tdonohue added this to the 7.2 milestone Dec 2, 2021
@tdonohue tdonohue moved this from To Do to In Progress in DSpace 7.2 release Dec 2, 2021
DSpace 7.2 release automation moved this from In Progress to Done Dec 22, 2021
@tdonohue tdonohue added this to To Do in DSpace 7.x Tier 2: Medium High Priority via automation Jan 31, 2022
@tdonohue tdonohue moved this from To Do to Under Review in DSpace 7.x Tier 2: Medium High Priority Jan 31, 2022
@tdonohue tdonohue moved this from Under Review to Done in DSpace 7.x Tier 2: Medium High Priority Jan 31, 2022
4science-it pushed a commit to 4Science/dspace-angular that referenced this issue Oct 12, 2023
[DSC-1253]

Approved-by: Giuseppe Digilio
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug e/24 Estimate in hours
Projects
Development

Successfully merging a pull request may close this issue.

3 participants