Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a DSO doesn't exist, we should show the 404 component. #865

Closed
artlowel opened this issue Sep 16, 2020 · 1 comment · Fixed by #891
Closed

When a DSO doesn't exist, we should show the 404 component. #865

artlowel opened this issue Sep 16, 2020 · 1 comment · Fixed by #891
Assignees
Labels
bug e/4 Estimate in hours
Milestone

Comments

@artlowel
Copy link
Member

Describe the bug
If the id for a DSO can't be found you don't see the 404 component, instead the page will be broken.

To Reproduce
Steps to reproduce the behavior:

  1. enter the url of a community, collection or item page with a UUID that doesn't exist

Expected behavior
You should see the 404 component. The URL should still be the one you entered.

I expect this will take 4h to fix.

@artlowel artlowel added bug needs triage New issue needs triage and/or scheduling labels Sep 16, 2020
@artlowel
Copy link
Member Author

The exception suggested here could be a clean way of handling this issue, however, it is unclear whether it is something that works right now, or is a suggestion for the angular devs: angular/angular#29089 (comment)

@tdonohue tdonohue added e/4 Estimate in hours and removed needs triage New issue needs triage and/or scheduling labels Sep 16, 2020
@tdonohue tdonohue added this to To Do in DSpace 7 Beta 5 via automation Sep 16, 2020
@tdonohue tdonohue added this to the 7.0beta5 milestone Sep 16, 2020
@artlowel artlowel self-assigned this Oct 8, 2020
@artlowel artlowel moved this from To Do to In Progress in DSpace 7 Beta 5 Oct 8, 2020
Atmire-Kristof added a commit to atmire/dspace-angular that referenced this issue Oct 13, 2020
@Atmire-Kristof Atmire-Kristof mentioned this issue Oct 13, 2020
6 tasks
4science-it pushed a commit to 4Science/dspace-angular that referenced this issue Sep 22, 2023
[DSC-1255] complete translation of it.json5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug e/4 Estimate in hours
Projects
No open projects
DSpace 7 Beta 5
  
In Progress
Development

Successfully merging a pull request may close this issue.

2 participants