Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple Search fixes for merge related issues #162

Conversation

LotteHofstede
Copy link
Contributor

This PR connects to #161
Added some routing fixes so the search page can be used again.
Updated the search-page component to also use lazy loading.
Some other minor (merge related) fixes/updates to the simple search feature.

@ghost ghost assigned LotteHofstede Oct 4, 2017
@ghost ghost added the needs review label Oct 4, 2017
@LotteHofstede LotteHofstede mentioned this pull request Oct 4, 2017
@ghost
Copy link

ghost commented Oct 4, 2017

LGTM

Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too. Thanks @LotteHofstede !

@artlowel artlowel merged commit 5e8e896 into DSpace:master Oct 4, 2017
@ghost ghost removed the needs review label Oct 4, 2017
@tdonohue tdonohue added this to the 7.0preview milestone Jan 26, 2021
4science-it pushed a commit to 4Science/dspace-angular that referenced this pull request Apr 29, 2022
[DSC-544] Workflow item task not showing correction change request

Approved-by: Giuseppe Digilio
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants