Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make label and error messages for license-step accept-checkbox translatable #1708

Merged
merged 1 commit into from Jul 27, 2022

Conversation

toniprieto
Copy link
Contributor

@toniprieto toniprieto commented Jun 27, 2022

References

Description

Make label and error messages for license-step accept-checkbox translatable and add translation for English and Spanish.

Instructions for Reviewers

List of changes in this PR:

Include guidance for how to test or review your PR.

Start a new submission and check that the checkbox label and the error message that appears when the checkbox is unchecked are translated for Spanish and English.

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR doesn't introduce circular dependencies
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

@tdonohue tdonohue added bug i18n / l10n Internationalisation and localisation, related to message catalogs component: submission labels Jun 27, 2022
@tdonohue tdonohue added this to Needs Reviewers Assigned in DSpace 7.4 release via automation Jun 27, 2022
@tdonohue tdonohue added the 1 APPROVAL pull request only requires a single approval to merge label Jul 13, 2022
@tdonohue tdonohue moved this from Needs Reviewers Assigned to Under Review in DSpace 7.4 release Jul 14, 2022
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @toniprieto ! This looks great to me. I tested it as well, and it works...the license checkbox now can be translated.

DSpace 7.4 release automation moved this from Under Review to Reviewer Approved Jul 27, 2022
@tdonohue tdonohue added this to the 7.4 milestone Jul 27, 2022
@tdonohue tdonohue merged commit f80e72d into DSpace:main Jul 27, 2022
DSpace 7.4 release automation moved this from Reviewer Approved to Done Jul 27, 2022
@toniprieto toniprieto deleted the translate-accept-license-step branch November 7, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug component: submission i18n / l10n Internationalisation and localisation, related to message catalogs
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Make label and error messages for license-step accept-checkbox available to i18n
2 participants