-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advanced workflow actions - framework & workflows scoreReview
and selectSingleReviewer
#2039
Advanced workflow actions - framework & workflows scoreReview
and selectSingleReviewer
#2039
Conversation
…dvancedWorkflowActionSelectReviewerComponent
…lay error for empty reviewers list
…_advanced-workflow-actions-main # Conflicts: # src/app/access-control/access-control.module.ts # src/app/access-control/group-registry/group-form/eperson-list/eperson-list.component.spec.ts # src/app/access-control/group-registry/group-form/eperson-list/eperson-list.component.ts # src/app/access-control/group-registry/group-form/members-list/members-list.component.ts # src/assets/i18n/en.json5
…_advanced-workflow-actions-main
Hi @MarieVerdonck, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
…_advanced-workflow-actions-main # Conflicts: # src/app/core/core.module.ts # src/app/workflowitems-edit-page/advanced-workflow-action/advanced-workflow-action-select-reviewer/reviewers-list/reviewers-list.component.spec.ts
…workflow-actions-main # Conflicts: # src/app/shared/shared.module.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @MarieVerdonck
I've not yet fully reviewed but I'm adding a first suggestion
…_advanced-workflow-actions-main # Conflicts: # yarn.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks @MarieVerdonck and @alexandrevryghem ! I've retested this today. I've verified that the fixes to the backend PR have fixed the bug related to the "Decline" button (in SingleReviewer workflow). I've also verified that after the removal of ngx-bootstrap
, the scoreReview workflow is still working properly.
@atarix83 : Please give this a re-review, as @alexandrevryghem was able to remove ngx-bootstrap
as you requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested it and it's overall good.
I just have to report a small malfunctions when navigating among the new workflow pages and the mydspace page.
and then from the workflow rating page i click on the back button, I'm redirected to the previous page but the url contains wrong encoded chars and as a result the item is not found because the search is wrong
- with the selecting reviewer(s) workflow instead when passing back from the select reviewer(s) page and the mydspace page the query search is not maintened
This is not a big issue but if it can be resolved quickly it'd be great.
For the rest this is a +1 for me
…tionPageComponent.previousPage()
…ons-7.2' into w2p-98211_advanced-workflow-actions-main # Conflicts: # src/app/shared/testing/active-router.stub.ts # src/app/workflowitems-edit-page/advanced-workflow-action/advanced-workflow-action-select-reviewer/advanced-workflow-action-select-reviewer.component.ts
23ad4e7
to
67c6684
Compare
@atarix83 can you give it a re-review? Both problems should be fixed now |
…_advanced-workflow-actions-main # Conflicts: # src/app/shared/testing/active-router.stub.ts
…_advanced-workflow-actions-main
…_advanced-workflow-actions-main
Hi @MarieVerdonck, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
@MarieVerdonck & @alexandrevryghem : My apologies, another merger caused more merge conflicts here. @atarix83 : Can you re-review this today? If not, I can try and verify the issues you found are now fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @MarieVerdonck
it's working properly now, after the merge conflicts are resolved this PR can be merged
# Conflicts: # src/app/shared/shared.module.ts
References
Fixes #770
Corresponding REST PR: DSpace/DSpace#8629
Description
Framework for advanced workflow steps/actions, i.e. actions that can't easily be represented by just a button (with possible modal) but will rather open in a new page.
Pages for the two already configured more advanced workflows:
selectSingleReviewer
andscoreReview
have also been added.Instructions for Reviewers
scoreReview workflow
scoreReview
workflow test & configure inworkflow.xml
that collection's handle for thescoreReview
workflowrequiredUsers
is 2)/mydspace?configuration=workflow
=> This user should be able to claim created item in workflowworkflow-actions.xml
descriptionRequired
andmaxValue
should alter this formdescriptionRequired=true
=> will be prevented; if set to false can still be sent / saved on item but it optionalworkflow.score
andworkflow.review
dc.decription.provenance
indicating it was rejected because of insufficient score (/server/api/submission/workspaceitems/{wsiId}/item
)workflow
metadataworkflow-actions.xml
configminimumAcceptanceScore
determines minimum mean)dc.decription.provenance
indicating it was accepted with mean score & reviews entered (/server/api/core/items/{itemUuid}
)workflow
metadataselectSingleReviewer workflow
selectSingleReviewer
workflow test & configure inworkflow.xml
that collection's handle for theselectSingleReviewer
workflow (configure in edit collection > assign roles the submitters group with at least 1 submitter)/mydspace?configuration=workflow
=> This user should be able to claim created item in workflowaction.selectrevieweraction.group = Reviewers
) - test pagination/mydspace?configuration=workflow
=> This user should have the item it was selected as reviewer for already claimed (auto assign selection configured) and should have buttons for options: accept, reject (with reason) and decline taskdc.description.provenance
dc.decription.provenance
indicating it was rejected including who rejected it with their entered reason (/server/api/submission/workspaceitems/{wsiId}/item
)Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn lint
yarn check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.