Advance search search page

[GauravD2t]

References

• Fixes Provide an Advanced Search page with Boolean options DSpace#8431 (if this fixes an issue ticket)

Description

The operator drop-down list should have four values: Contains, Not Contains, Equals, and Not Equals.
The operator drop-down list should move above the text field in the Advanced Search section.
The advanced search options should be removed from individual facets (Author, Subject, etc)

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

• First, ...
• Second, ...

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using yarn lint
• My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[github-actions]

Hi @GauravD2t,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

[tdonohue]

@GauravD2t : I retested this today and it's working much better now. I've only found one bug.

• If the Advanced Search returns no results, all of the additional "Filters" disappear. See this screenshot where the "Author", "Subject", Date", etc have all disappeared from the "Filters" sidebar
  
  • Here's how I reproduced that
  • Go to the Search page, and perform a "Title" "Equals" search for a title that doesn't exist
  • You'll get no results and all the other filters will disappear from the page.

Beyond that, I also have noticed that there are still i18n keys being removed from the en.json5 file. Removing those i18n keys causes other features to break. So this MUST be fixed before this PR can be merged.

[GauravD2t]

@GauravD2t : I retested this today and it's working much better now. I've only found one bug.

• If the Advanced Search returns no results, all of the additional "Filters" disappear. See this screenshot where the "Author", "Subject", Date", etc have all disappeared from the "Filters" sidebar
  

  • Here's how I reproduced that
  • Go to the Search page, and perform a "Title" "Equals" search for a title that doesn't exist
  • You'll get no results and all the other filters will disappear from the page.

Beyond that, I also have noticed that there are still i18n keys being removed from the en.json5 file. Removing those i18n keys causes other features to break. So this MUST be fixed before this PR can be merged.

filters come base on searching value

[github-actions]

Hi @GauravD2t,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

[tdonohue]

👍 @GauravD2t : Thanks for the updates & for explaining why the filters disappear when a search fails. This looks good to me now. That said, I did need to correct a minor typo in config.example.yml as it said filters instead of filter. Once this completes it's rebuild, I'll merge it.