[Port dspace-7_x] Refactored community & collection pages #2832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n empty (cherry picked from commit 6f51bd8)
alexandrevryghem
added
bug
component: Discovery
tdonohue
requested changes
Feb 28, 2024
There was a problem hiding this comment.
@alexandrevryghem : Thanks for creating this port. The good news is this fixes the #2808 bug with Browse by Date. The bad news, though, it seems to break some of the other Browse By pages. Here's what I tried:
- I ran this PR in production mode (
yarn build:prod; yarn serve:ssr) against the demo.dspace.org backend, comparing it to the results at https://demo.dspace.orgrest: ssl: true host: demo.dspace.org port: 443 nameSpace: /server - Browse by Date works perfectly now, even if I delete the
dc.date.issuedfield in the first result, or if I update it so that it has an empty value - Browse by Title no longer works. Page never loads
- Browse by Author will load the author list. But, if you click on an Author name the next page no longer works. Page never loads
- Browse by Subject shows the same behavior as Browse by Author. List of subjects will load, but if you click on a Subject you cannot see the results for that subject.
I'm not sure what the exact cause is...but this PR seems to have unexpected side effects.
8 tasks
…instead of undefined, which prevented its default values from being used (cherry picked from commit e6bf2f0)
|
@tdonohue: This backport was indeed missing one fix, I cherry-picked it and everything seems to work correctly now |
tdonohue
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
👍 Thanks @alexandrevryghem ! I've verified this now fixes the bug on the dspace-7_x branch and has no adverse side effects to other browse by options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
Partial port of #2722 to
dspace-7_x: