Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synced the imports of the custom theme with the imports of the base component so custom theme works again #2984

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

kunovercammen
Copy link

References

Description

This PR fixes the issue where running the DSpace UI with the "custom" theme resulted in many features not working properly. The root cause was identified as the themed components having mismatched imports compared to their base components. The PR addresses this by ensuring that all themed components have the same imports as their base components.

Instructions for Reviewers

The changes made in this PR include:

  • Ensuring consistency in imports between themed components and their base components.
  • Verifying that all fixed components now work correctly in the custom theme.

Testing Instructions:

  1. Enable the custom theme.
  2. Build the UI in production mode using yarn build:prod and serve using yarn serve:ssr.
  3. Access the homepage and ensure that all features are working as expected.
  4. Repeat the above steps for individual item pages to ensure proper functionality.

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug themes 1 APPROVAL pull request only requires a single approval to merge labels Apr 26, 2024
@tdonohue tdonohue added this to the 8.0 milestone Apr 26, 2024
@tdonohue tdonohue self-requested a review April 26, 2024 14:12
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you @kunovercammen ! This fixes the bug. The custom theme now works again

@tdonohue
Copy link
Member

Merging even though the Codecov check above failed. Codecov is having issues...there's a bug impacting a lot of builds from GitHub. See DSpace/DSpace#9503 (comment)

@tdonohue tdonohue merged commit 3568acc into DSpace:main Apr 26, 2024
10 of 11 checks passed
ybnd added a commit to ybnd/dspace-angular that referenced this pull request Apr 30, 2024
This is part of the themed-component-usages rule; Themed* components already import the base component, we don't need to import both anymore.
You'll see that all of these changes are also reflected in the base component.

Double-checked and this doesn't compromise the fixes from DSpace#2984
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug high priority themes
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

The "custom" theme no longer works
2 participants