New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial entities PR #315
Initial entities PR #315
Changes from all commits
06d2ac7
26098c6
7db32b2
5fba750
e582f56
4ca8e84
5149c48
82977ce
f1b3557
e5fc17d
8423261
f50e0ed
c99d05c
34dbc24
1749194
733ca64
691b466
9012688
1805c76
01ab627
8ab6eb6
971cf0e
f1a8517
e084344
8ea8f11
d4c00db
bbd64c9
a5d6e63
9154076
b06629c
1231d3e
d06e8d9
cef2ea8
b68ed37
132d979
46daefd
addea8b
de2499b
20520ea
81d8940
363e145
66ae2fe
d8ce01b
8e3e826
4af12c2
278a664
41c8577
193d751
46eb9fa
5067793
35937a9
796b9b6
3a23b70
624fe2d
651b84b
26b0758
eab6698
b8a9fe0
221e20f
57ba31e
a66007c
7856738
33eb59a
cc369bf
028a2b5
39e1b0f
4d24802
e4eee7c
29e60f2
7914e1c
c1eab40
2d2d1da
d1db0d4
9918d95
b2ca67c
efcdc67
b70a58d
5d8c635
e39879b
1126af6
ec61240
626b9fe
ba92882
6d69c7d
7b6665d
3f98fed
19033e6
1ba7d1e
3988b7a
d32ec11
69aaa18
c5eb4b7
9c3f226
a7bebb1
6d44381
5ed2b75
593dcf7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,10 +10,10 @@ module.exports = { | |
// The REST API server settings. | ||
rest: { | ||
ssl: true, | ||
host: 'dspace7.4science.it', | ||
host: 'dspace7-entities.atmire.com', | ||
port: 443, | ||
// NOTE: Space is capitalized because 'namespace' is a reserved string in TypeScript | ||
nameSpace: '/dspace-spring-rest/api' | ||
nameSpace: '/rest/api' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Like the comment I did in Dspace API PR (), in order for this to work by default, you need to change this setting to "spring-rest" There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @paulo-graca : Again, I agree for the final release we'll want this set to the name of the REST API webapp. However, again (as commented above) for testing purposes we are setting this to the path of the current REST API demo site by default. |
||
}, | ||
// Caching settings | ||
cache: { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand the testing purpose, but I think this default file should be stuck to more default configurations like localhost.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paulo-graca : I agree for the final release. However, for the ongoing development of the Angular UI, we've decided to default it to point at our public REST API demo site. That makes PRs and code much easier to test because we don't require testers install the REST API locally (or figure out how to change this setting manually).
So, the plan is that the final DSpace 7 release will have this set to localhost. However, until then, we will keep it set to the public demo site for easy testing/development.