Fixed issue where facets could not be changed when you are logged in #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdonohue
approved these changes
Oct 31, 2018
There was a problem hiding this comment.
👍 I was able to reproduce the bug locally while logged in & performing searches. This PR fixes the issue, and looks good to me. Thanks @LotteHofstede
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overriding
this.router.routeReuseStrategy.shouldReuseRoutebreaks navigating to the same url but with different query parameters. This causes visible issues when you are logged in and try to add or remove facets on the search page.I replaced this by using
this.router.onSameUrlNavigation = 'reload'instead, as suggested here:angular/angular#13831 (comment)