Move item component #335
Move item component #335
Conversation
Conflicts: resources/i18n/en.json
There was a problem hiding this comment.
@YanaDePauw thanks for PR
I've made a quick test against DS-4096, move operation seems to work properly.
I've added some inline comment and other than these, I'd ask if is possible to add information about the current item collection in the move page
src/app/+item-page/edit-item-page/item-move/item-move.component.html
Outdated
Show resolved
Hide resolved
|
|
||
| /** | ||
| * Load all available collections to move the item to. | ||
| * TODO: When the API support it, only fetch collections where user has ADD rights to. |
There was a problem hiding this comment.
Collection endpoint has a findAuthorized method https://dspace7.4science.cloud/dspace-spring-rest/#https://dspace7.4science.cloud/dspace-spring-rest/api/core/collections/search/findAuthorized
Should be useful to only fetch collections where user has ADD rights to? It should be checked if it accepts the query parameter
There was a problem hiding this comment.
Unfortunately, this endpoint does not allow a user to search for a collection (using name or uuid), which means it cannot be used in suggestion based dropdown menu.
What I ideally would need is an endpoint that finds the authorized collections that also correspond to a certain search query.
Add a title to the move page Disable submit button when no target is selected Add operation in progress indicator Use updated inputSuggestion to fix bug with value selection
There was a problem hiding this comment.
The overall functionality here appears to work, based on basic tests. However, the code branch is outdated (needs updating to latest master, and also merge conflict resolved). I added a few inline comments of things to cleanup as well (and I agree with the notes @atarix83 already added)
src/app/+item-page/edit-item-page/edit-item-page.routing.module.ts
Outdated
Show resolved
Hide resolved
Conflicts: resources/i18n/en.json src/app/+item-page/edit-item-page/item-metadata/edit-in-place-field/edit-in-place-field.component.spec.ts src/app/+item-page/edit-item-page/item-metadata/edit-in-place-field/edit-in-place-field.component.ts
|
@YanaDePauw thanks for making the required changes. I review again and it looks good, I should report only a little annoying behavior. |
|
Fixed the issue with the links being clickable. |
There was a problem hiding this comment.
👍 Retested & re-reviewed today. This works as described and the code looks good. Thanks @YanaDePauw !
However, the PR must be rebased on the lastest master before it can be merged, as it has code conflicts.
There was a problem hiding this comment.
@YanaDePauw thanks for making the required changes.
I've reviewed again and it all looks good to me
[DSC-768] Inner form discard icon overlays form buttons Fixed Approved-by: Davide Negretti
Add the item move component to the Edit Item menu.
This feature is based on the “Move…” feature in DSpace 6. When clicking the “Move…” button in the “Edit Item” menu, the user will be redirected to a page where the user can select a collection. A search box will be present that allows the user to enter a query to narrow down the list of collections.
To avoid a big dropdown menu, the maximum amount of collections is restricted to 10. In case the collection is not present in the list, the search menu needs to be used to narrow down the results to a list that does contain the collection. Clicking the collection in the dropdown will select it.
A checkbox is present to indicate whether policies from the new collection need to be inherited. No support is present yet in the backend, so this is added as a TODO in the code.
This TODO refers to #333
Another TODO is present in the code. Currently no support is present to only display a collection to which the current user has ADD rights.
This issue is addressed in #334
To test the functionality, navigate to an item page, add "/edit" at the url, and click the Move button.
This PR depends on DSpace/DSpace#2283