Issue 331 migrate json language catalogs to po

[bram-atmire]

No description provided.

[paulo-graca]

Thank you @bram-atmire for adding this! I think your PR is a little far behind and needs to be synchronized to the latest version.

[artlowel]

There are a few escaping issues in the labels. Also, because the metadata as a map PR isn't merged in this branch yet, it's hard to test, because nothing using metadata will work properly.

[bram-atmire]

@artlowel @paulo-graca
Normally the build should now work and the tests should pass. I also made another rebase and made sure that both dspace.pot (the template file), as well as en.po (the English translations) are up to date with the latest keys in en.json.

To help with the transition, I made sure that:

• the original key name/path from en.json is available in .po and .pot comments
• the ORDER of the keys corresponds with the order in en.json to the extent possible.

Can we identify any remaining blockers for stopping adding new keys to en.json? Would really love to see if we can finalize the transition, so we can start on documentation and onboarding of translators and developers with the new way of working with translations.

Dipped into that "Poedit" software for managing the translations, and it really looks like a great tool that will make life a lot easier for translators.

[AlexanderS]

I found some minor issues, but overall this PR looks great.

[tdonohue]

👍 I have not tested this, but I reviewed the changes and I approve of this direction. Once merged, I'd recommend we start adding details/hints/tips for how to contribute new *.po files to these early docs: https://wiki.duraspace.org/display/DSPACE/DSpace+7+Translations (thanks for starting this @bram-atmire !)

[paulo-graca]

Again, thank you @bram-atmire for adding this. It was very simple to me to add a new Language and add some translations. It works fine!

[AlexanderS]

@bram-atmire Thanks for fixing my comments. Just a note: The current commit message looks a bit strange.

@tdonohue We could check if DSpace would qualify for the free open source tier of Transifex: https://docs.transifex.com/projects/open-source-project This would make it really easy to contribute new translations (there is a nice web editor).

[bram-atmire]

We still need to find a solution for dynamic built keys like like:

app/+admin/admin-registries/metadata-schema/metadata-field-form/metadata-field-form.component.html:4:    <h4>{{messagePrefix + '.create' | translate}}</h4>
app/+admin/admin-registries/metadata-schema/metadata-field-form/metadata-field-form.component.html:8:    <h4>{{messagePrefix + '.edit' | translate}}</h4>
app/shared/object-list/search-result-list-element/item-search-result/item-search-result-list-element.component.html:2:  <span class="badge badge-light">{{ type.toLowerCase() + '.listelement.badge' | translate }}</span>
app/shared/dso-selector/modal-wrappers/create-community-parent-selector/create-community-parent-selector.component.html:2:    <div class="modal-header">{{'dso-selector.'+ action + '.' + objectType.toString().toLowerCase() + '.head' | translate}}
app/shared/dso-selector/modal-wrappers/dso-selector-modal-wrapper.component.html:2:  <div class="modal-header">{{'dso-selector.'+ action + '.' + objectType.toString().toLowerCase() + '.head' | translate}}
app/+item-page/edit-item-page/item-operation/item-operation.component.html:3:        {{'item.edit.tabs.status.buttons.' + operation.operationKey + '.label' | translate}}
app/+item-page/edit-item-page/item-operation/item-operation.component.html:8:    {{'item.edit.tabs.status.buttons.' + operation.operationKey + '.button' | translate}}
app/+item-page/edit-item-page/item-operation/item-operation.component.html:13:    {{'item.edit.tabs.status.buttons.' + operation.operationKey + '.button' | translate}}
app/+item-page/edit-item-page/edit-item-page.component.html:11:                            {{'item.edit.tabs.' + page + '.head' | translate}}
app/+item-page/simple/field-components/specific-field/title/item-page-title-field.component.html:3:    {{ type.toLowerCase() + '.page.titleprefix' | translate }}

[artlowel]

Because the translation loader this PR is built on isn't actively maintained, has no support for server side rendering, and because the main developer behind ngx-translate isn't quite sure how much support he can give the project in the future, we decided in the meeting of 2019-07-25 to close this PR, and keep working with ngx-translate's native format for the time being.

To make translating easier for non-developers we'll create a PR to flatten the existing json files. We'll also look in to ways of converting the json files to po or xliff format and back, so those formats can still be used by translators, just not live in the application.

[tdonohue]

This PR is currently replaced by #439. More thoughts/opinions welcome there.