Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Configurable Entities] final master merge #396

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
81 commits
Select commit Hold shift + click to select a range
e7f5372
Fixed an issue with license in collection page
atarix83 Feb 28, 2019
f35b1ca
restored name property to NormalizedEPerson class
atarix83 Feb 28, 2019
22ebbd5
Fixed an issue with save of repeatable scrollable-dropdown fields
atarix83 Feb 28, 2019
f861fc1
Refactored JsonPatchOperationPathCombiner extending URLCombiner
atarix83 Feb 28, 2019
ebb77b2
Added mydspace page components
atarix83 Mar 8, 2019
f07aafa
Added services and models
atarix83 Mar 8, 2019
af75bea
Added navigation bar user menu
atarix83 Mar 8, 2019
185d072
Added message board components
atarix83 Mar 8, 2019
d7ba427
Added mydspace actions components
atarix83 Mar 8, 2019
f0a6d7a
Added mydspace results components
atarix83 Mar 8, 2019
52906e7
Intermediate commit
atarix83 Mar 8, 2019
11e7708
Merge remote-tracking branch 'remotes/origin/submission' into mydspace
atarix83 Mar 11, 2019
013d464
Intermediate commit
atarix83 Mar 11, 2019
c9cd9ce
Merge remote-tracking branch 'remotes/upstreamatmire/Search-optimizat…
atarix83 Mar 26, 2019
b871148
fixes after merge
atarix83 Mar 26, 2019
c1ccf43
Merge remote-tracking branch 'remotes/upstreamatmire/Search-optimizat…
atarix83 Mar 26, 2019
67c9fc9
Fixes
atarix83 Mar 26, 2019
9b65189
Fixed build errors
atarix83 Mar 26, 2019
39b98f7
Fixed unit tests
atarix83 Mar 27, 2019
60f9df9
Merge remote-tracking branch 'remotes/origin/submission' into mydspace
atarix83 Mar 27, 2019
237100a
fixed after merge
atarix83 Mar 27, 2019
96bb4e9
Removed wrong initialization
atarix83 Mar 27, 2019
c442166
Added tests
atarix83 Mar 28, 2019
eeea331
Fixed issue with initialization of child class
atarix83 Mar 28, 2019
6b40efd
Fixed loadin spin icon
atarix83 Mar 28, 2019
c613fb2
Removed view detail button from pool task
atarix83 Mar 28, 2019
1a57fe7
Added comments
atarix83 Mar 28, 2019
6616d75
Renamed mydspace results components and files
atarix83 Mar 28, 2019
7b63d14
Added more tests and comments
atarix83 Mar 28, 2019
ad9ccdd
Merge remote-tracking branch 'remotes/origin/master' into mydspace
atarix83 Apr 1, 2019
607beb1
Added ClaimedTaskActionsReturnToPoolComponent
atarix83 Apr 2, 2019
16b8e91
Added tests and comments
atarix83 Apr 2, 2019
49aee18
Added tests and comments
atarix83 Apr 2, 2019
080e0be
Added tests and comments
atarix83 Apr 2, 2019
25d955c
Added tests and comments
atarix83 Apr 2, 2019
af2a995
Fixed build error
atarix83 Apr 3, 2019
7c48504
renamed dspaceObject to indexableObject
atarix83 Apr 3, 2019
ceb0e7e
Fixed unexpected error exception during test
atarix83 Apr 3, 2019
589b0ea
renamed dspaceObject to indexableObject
atarix83 Apr 3, 2019
42fa673
Use search link to retrieve filter values
atarix83 Apr 3, 2019
030dd20
Fixed visualization of pagination info div
atarix83 Apr 3, 2019
f9b96dc
fixed test
atarix83 Apr 3, 2019
bbc27fe
refactored ItemDetailPreviewComponent
atarix83 Apr 3, 2019
71c0c1b
Fixed an issue with place property removal from object that represent…
atarix83 Apr 4, 2019
174c4f6
Implemented authority facet
atarix83 Apr 5, 2019
5491534
Removed message board components
atarix83 Apr 5, 2019
a2b91eb
Changed mydspace item status labels
atarix83 Apr 5, 2019
90b88de
Changed mydspace item status labels
atarix83 Apr 5, 2019
676f2b4
Changed mydspace item status labels
atarix83 Apr 5, 2019
3d87371
Fixed mydspace page layout
atarix83 Apr 5, 2019
9b452c9
Fixed switch view pagination issue
atarix83 Apr 5, 2019
156b51f
Fixed test
atarix83 Apr 5, 2019
330a706
Refactored ItemDetailPreviewComponent
atarix83 Apr 5, 2019
7324e22
Fixed test
atarix83 Apr 5, 2019
94b9017
Removed border from last mydspace item result
atarix83 Apr 5, 2019
ce9e334
Fixed issue occurred when selecting more than one facet value
atarix83 Apr 18, 2019
b48693d
Fixed issue occurred when deselecting a selected facet value
atarix83 Apr 18, 2019
4b7b61d
Merge remote-tracking branch 'remotes/origin/master' into mydspace
atarix83 Apr 18, 2019
ca7e879
Created MyDSpaceRequest to avoid use of forceBypassCache flag
atarix83 Apr 19, 2019
c959b49
Removed unsed services
atarix83 Apr 19, 2019
86324c3
Changes based on review feedback
atarix83 Apr 19, 2019
ea3f3cb
Renamed prepareBody to uriEncodeBody
atarix83 Apr 19, 2019
2a0f6fa
Removed link color from item title in the mydspace results list
atarix83 Apr 19, 2019
dfd8a69
Added param to hide pagination details
atarix83 Apr 19, 2019
ff7aa33
hide pagination details from mydspace item detail view
atarix83 Apr 19, 2019
7492c21
added test for MyDSpaceNewSubmissionComponent
atarix83 Apr 25, 2019
38f958e
Added typedoc comments
atarix83 Apr 25, 2019
ea81a44
Merge remote-tracking branch 'remotes/origin/master' into mydspace
atarix83 Apr 25, 2019
fe4ad00
Merge remote-tracking branch 'remotes/origin/master' into mydspace
atarix83 Apr 25, 2019
1c92e82
fixed test
atarix83 Apr 25, 2019
9a55771
align new submission button with upload drop zone
atarix83 Apr 25, 2019
31e2a9c
added preserveWhitespaces to angularCompilerOptions
atarix83 Apr 25, 2019
2a12488
added default value for onBeforeUpload property
atarix83 May 2, 2019
4f7299f
Fixes for SubmissionResponseParsingService
atarix83 May 2, 2019
137416c
Changed default rest server
atarix83 May 9, 2019
7ea34ac
Fixed getSearchLink method with pages with embedded search
atarix83 May 9, 2019
718931a
fixed build error
atarix83 May 9, 2019
9e0846a
Merge pull request #384 from 4Science/mydspace
tdonohue May 10, 2019
0390f67
Merge branch 'master' into w2p-62372_Final-master-merge
Atmire-Kristof May 13, 2019
b0f9ce9
62372: Post-merge test fixes
Atmire-Kristof May 13, 2019
5c4691b
62372: ItemTypeSwitcher bugfix
Atmire-Kristof May 13, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
133 changes: 129 additions & 4 deletions resources/i18n/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
"uri": "URI",
"files": "Files",
"collections": "Collections",
"subject": "Keywords",
"subject": "Keywords",
"citation": "Citation",
"filesection": {
"download": "Download",
Expand Down Expand Up @@ -392,6 +392,7 @@
},
"login": "Log In",
"logout": "Log Out",
"mydspace": "MyDSpace",
"language": "Language switch",
"search": "Search"
},
Expand Down Expand Up @@ -428,6 +429,57 @@
"help": "Select a community to browse its collections."
}
},
"mydspace": {
"title": "MyDSpace",
"description": "",
"new-submission": "New submission",
"results": {
"head": "Your submissions",
"no-results": "There were no items to show",
"no-title": "No title",
"no-authors": "No Authors",
"no-date": "No Date",
"no-abstract": "No Abstract",
"no-files": "No Files",
"no-uri": "No Uri",
"no-collections": "No Collections"
},
"messages": {
"title": "Messages",
"to": "To",
"hide-msg": "Hide message",
"show-msg": "Show message",
"no-messages": "No messages yet.",
"no-content": "No content.",
"send-btn": "Send",
"subject-placeholder": "Subject...",
"description-placeholder": "Insert your message here...",
"mark-as-read": "Mark as read",
"mark-as-unread": "Mark as unread",
"submitter-help": "Select this option to send a message to controller.",
"controller-help": "Select this option to send a message to item's submitter."
},
"show": {
"workspace": "Your Submissions",
"workflow": "All tasks"
},
"status": {
"workflow": "Workflow",
"validation": "Validation",
"waiting-for-controller": "Waiting for controller",
"workspace": "Workspace",
"archived": "Archived"
},
"view-btn": "View",
"general": {
"text-here": "HERE"
},
"upload": {
"upload-successful": "New workspace item created. Click {{here}} for edit it.",
"upload-multiple-successful": "{{qty}} new workspace items created.",
"upload-failed": "Error creating new workspace. Please verify the content uploaded before retry."
}
},
"search": {
"journal": {
"title": "DSpace Angular :: Journal Search",
Expand All @@ -451,7 +503,8 @@
"description": "",
"form": {
"search": "Search",
"search_dspace": "Search DSpace"
"search_dspace": "Search DSpace",
"search_mydspace": "Search MyDSpace"
},
"results": {
"head": "Search Results",
Expand All @@ -471,9 +524,13 @@
"rpp": "Results per page"
}
},
"switch-configuration": {
"title":"Show"
},
"view-switch": {
"show-list": "Show as list",
"show-grid": "Show as grid"
"show-grid": "Show as grid",
"show-detail": "Show detail"
},
"filters": {
"head": "Filters",
Expand All @@ -484,7 +541,11 @@
"f.dateIssued.max": "End date",
"f.subject": "Subject",
"f.has_content_in_original_bundle": "Has files",
"f.entityType": "Item Type"
"f.entityType": "Item Type",
"f.namedresourcetype": "Status",
"f.dateSubmitted": "Date submitted",
"f.itemtype": "Type",
"f.submitter": "Submitter"
},
"filter": {
"show-more": "Show more",
Expand Down Expand Up @@ -516,6 +577,26 @@
"entityType": {
"placeholder": "Item Type",
"head": "Item Type"
},
"namedresourcetype": {
"placeholder": "Status",
"head": "Status"
},
"dateSubmitted": {
"placeholder": "Date submitted",
"head": "Date submitted"
},
"itemtype": {
"placeholder": "Type",
"head": "Type"
},
"submitter": {
"placeholder": "Submitter",
"head": "Submitter"
},
"objectpeople": {
"placeholder": "People",
"head": "People"
}
}
}
Expand Down Expand Up @@ -736,6 +817,7 @@
"item": "Loading item...",
"objects": "Loading...",
"search-results": "Loading search results...",
"mydspace-results": "Loading items...",
"browse-by": "Loading items...",
"browse-by-page": "Loading page..."
},
Expand Down Expand Up @@ -927,6 +1009,49 @@
}
}
}
},
"workflow": {
"generic": {
"delete": "Delete",
"delete-help": "If you would to discard this item, select \"Delete\". You will then be asked to confirm it.",
"edit": "Edit",
"edit-help": "Select this option to change the item's metadata.",
"view": "View",
"view-help": "Select this option to view the item's metadata."
},
"tasks": {
"generic": {
"processing": "Processing...",
"success": "Operation successful",
"error": "Error occurred during operation...",
"submitter": "Submitter"
},
"claimed": {
"approve": "Approve",
"approve_help": "If you have reviewed the item and it is suitable for inclusion in the collection, select \"Approve\".",
"edit": "Edit",
"edit_help": "Select this option to change the item's metadata.",
"reject": {
"submit": "Reject",
"reason": {
"submit": "Reject item",
"title": "Reason",
"info": "Please enter your reason for rejecting the submission into the box below, indicating whether the submitter may fix a problem and resubmit.",
"placeholder": "Describe the reason of reject"
}
},
"reject_help": "If you have reviewed the item and found it is <strong>not</strong> suitable for inclusion in the collection, select \"Reject\". You will then be asked to enter a message indicating why the item is unsuitable, and whether the submitter should change something and resubmit.",
"return": "Return to pool",
"return_help": "Return the task to the pool so that another user may perform the task."

},
"pool": {
"claim": "Claim",
"claim_help": "Assign this task to yourself.",
"show-detail": "Show detail",
"hide-detail": "Hide detail"
}
}
}
},
"uploader": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ describe('MetadataFieldFormComponent', () => {
const registryServiceStub = {
getActiveMetadataField: () => observableOf(undefined),
createOrUpdateMetadataField: (field: MetadataField) => observableOf(field),
cancelEditMetadataField: () => {},
cancelEditMetadataSchema: () => {},
};
const formBuilderServiceStub = {
Expand Down Expand Up @@ -62,6 +63,11 @@ describe('MetadataFieldFormComponent', () => {
registryService = s;
}));

afterEach(() => {
component = null;
registryService = null
})

describe('when submitting the form', () => {
const element = 'fakeElement';
const qualifier = 'fakeQualifier';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { Component } from '@angular/core';
import { ActivatedRoute, Router } from '@angular/router';
import { EditComColPageComponent } from '../../shared/comcol-forms/edit-comcol-page/edit-comcol-page.component';
import { NormalizedCollection } from '../../core/cache/models/normalized-collection.model';
import { Collection } from '../../core/shared/collection.model';
import { CollectionDataService } from '../../core/data/collection-data.service';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { fadeIn, fadeInOut } from '../../shared/animations/fade';
import { ChangeDetectionStrategy, Component, OnInit } from '@angular/core';
import { ActivatedRoute, Params, Router } from '@angular/router';
import { ActivatedRoute, Router } from '@angular/router';
import { RemoteData } from '../../core/data/remote-data';
import { Item } from '../../core/shared/item.model';
import { Observable } from 'rxjs';
Expand Down
4 changes: 0 additions & 4 deletions src/app/+item-page/item-page.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@ import { GenericItemPageFieldComponent } from './simple/field-components/specifi

import { ItemPageComponent } from './simple/item-page.component';
import { ItemPageRoutingModule } from './item-page-routing.module';
import { MetadataValuesComponent } from './field-components/metadata-values/metadata-values.component';
import { MetadataUriValuesComponent } from './field-components/metadata-uri-values/metadata-uri-values.component';
import { MetadataFieldWrapperComponent } from './field-components/metadata-field-wrapper/metadata-field-wrapper.component';
import { ItemPageAuthorFieldComponent } from './simple/field-components/specific-field/author/item-page-author-field.component';
import { ItemPageDateFieldComponent } from './simple/field-components/specific-field/date/item-page-date-field.component';
import { ItemPageAbstractFieldComponent } from './simple/field-components/specific-field/abstract/item-page-abstract-field.component';
Expand Down Expand Up @@ -44,9 +42,7 @@ import { RelatedEntitiesSearchComponent } from './simple/related-entities/relate
declarations: [
ItemPageComponent,
FullItemPageComponent,
MetadataValuesComponent,
MetadataUriValuesComponent,
MetadataFieldWrapperComponent,
ItemPageAuthorFieldComponent,
ItemPageDateFieldComponent,
ItemPageAbstractFieldComponent,
Expand Down
2 changes: 1 addition & 1 deletion src/app/+item-page/simple/item-page.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,6 @@ export class ItemPageComponent implements OnInit {
this.thumbnail$ = this.itemRD$.pipe(
map((rd: RemoteData<Item>) => rd.payload),
filter((item: Item) => hasValue(item)),
mergeMap((item: Item) => item.getThumbnail()),);
mergeMap((item: Item) => item.getThumbnail()));
}
}
4 changes: 4 additions & 0 deletions src/app/+my-dspace-page/my-dspace-configuration-value-type.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
export enum MyDSpaceConfigurationValueType {
Workspace = 'workspace',
Workflow = 'workflow'
}
Loading