Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI language cookie #443

Merged
merged 5 commits into from Sep 5, 2019
Merged

UI language cookie #443

merged 5 commits into from Sep 5, 2019

Conversation

Atmire-Kristof
Copy link
Contributor

@Atmire-Kristof Atmire-Kristof commented Jul 31, 2019 •
edited

This PR adds the storage of the chosen UI language in a cookie.
When the app is initialised, the language is automatically set to the one found in the cookie (when available).
This also works server-side (for the first page request).

tdonohue
tdonohue approved these changes Aug 9, 2019
View reviewed changes
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Code looks good to me. I also tested it in my browser, and I can see the Cookie was set when I switch languages. Then if I close the tab and go back to the site, the language selection is kept.

paulo-graca
paulo-graca approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@paulo-graca paulo-graca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you @Atmire-Kristof once again!

@artlowel artlowel merged commit f9c5768 into DSpace:master Sep 5, 2019
@benbosman benbosman deleted the UI-language-cookie branch September 11, 2020 07:49
@tdonohue tdonohue added this to the 7.0beta1 milestone Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdonohue tdonohue tdonohue approved these changes

@paulo-graca paulo-graca paulo-graca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0beta1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Atmire-Kristof @tdonohue @paulo-graca @artlowel