Bitstream format registries #455
Conversation
Conflicts: src/app/+admin/admin-registries/bitstream-formats/bitstream-formats.component.spec.ts src/app/core/core.module.ts src/app/core/registry/registry-bitstreamformats-response.model.ts src/app/core/registry/registry.service.ts src/app/core/shared/bitstream-format.model.ts
Conflicts: resources/i18n/en.json
There was a problem hiding this comment.
Thanks @YanaDePauw!
Everything works as it should, but I made a few small inline comments.
Also a usability note: when adding an extension I wondered briefly whether I should prefix it with a point or not. Perhaps add a help text to clarify that you shouldn't.
Finally, if try to use a bitstream format short description that already exists, you are allowed to submit it. When you do, you get an error message saying that it failed, without a reason why.
It would be nice if we had a validator to check whether a short description is unique as you're typing, but I realize there is currently no rest endpoint that would allow you to write that validator. So I'll bring it up in the next meeting, and if we agree that it's worth the effort, that validator can be created in a separate PR.
.../admin-registries/bitstream-formats/add-bitstream-format/add-bitstream-format.component.html
Outdated
Show resolved
Hide resolved
src/app/+admin/admin-registries/bitstream-formats/bitstream-formats.component.html
Outdated
Show resolved
Hide resolved
src/app/+admin/admin-registries/bitstream-formats/bitstream-formats.component.ts
Outdated
Show resolved
Hide resolved
Change padding into margin Change 'Create link' to a button Add placeholder to extension field Fix pagination
There was a problem hiding this comment.
@artlowel I made a change to the extension field to use a placeholder with some additional info about the extension.
The reason for this was that I could not add a hint easily to the repeatable field. When I added a hint, it would be repeated for every input box which looked worse than using a placeholder.
There was a problem hiding this comment.
👍 Tested this today, and it works great. Thanks @YanaDePauw !
One tiny improvement to think about (for a future PR likely)... the order of formats in the registry seems "random" (I'm guessing they are ordered by internal ID perhaps?). The randomish ordering makes it very difficult to local a particular bitstream format to edit/update (you basically have to keep paging till you see it).
So, ideally, at some point, there'd either be a way to reorder the entries (perhaps by name by default), or a way to search within them (to find the one you want).
Nonetheless, I think this is a good initial version of the registry. So, I'm fine with this PR being merged as-is.
|
@tdonohue It doesn't seem like the rest endpoint supports any way to sort the bitstreamformats. We can't add sorting client side, since the rest response is paginated. So I'll merge this PR now as is |
try to append server/ to test gh action
This PR will add the functionality necessary to create, update and delete bitstream formats available in the admin registries.
The bitstream-format overview has been updated to allow deletion of formats by selecting formats using checkboxes and clicking a delete button.
A link has been added on the page to create new bitstream formats that will redirect the user to a form where all bitstream format info can be filled in.
Furthermore, the available bitstream formats on the overview page can be clicked which will redirect the user to an edit form similar to the create form that can be used to update the bitstream format.