Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the labels on edit collection and community pages #459

Merged
merged 1 commit into from Aug 29, 2019

Conversation

artlowel
Copy link
Member

The i18n labels on edit collection and community pages are based on the resource type. It used to be a string, but was changed in to an object recently causing the i18n labels to break:

image

This PR fixes that

Copy link
Contributor

@atarix83 atarix83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me

Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me too! Thanks!

@tdonohue tdonohue merged commit c80542c into DSpace:master Aug 29, 2019
@benbosman benbosman deleted the edit-com-col-labels branch September 11, 2020 07:52
@tdonohue tdonohue added this to the 7.0beta1 milestone Jan 26, 2021
kosarko pushed a commit to kosarko/dspace-angular that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants