Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple dso type values in discovery #845

Conversation

MarieVerdonck
Copy link
Contributor

@MarieVerdonck MarieVerdonck commented Aug 27, 2020

Description

This PR adds functionality to do a search where multiple dsoTypes are allowed to be returned (instead of just one or all). This is used by the export metadata modal in admin sidebar to export collections and communities (created in #798). 
Other search modals still expect just one type of dso in their results and the general search works as before.

In the statistics search event request creation, just the first one of the list of dsoTypes is added since the regular search will not have multiple dsoTypes and admin sidebar search will not count towards statistics

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

@MarieVerdonck MarieVerdonck changed the title W2p 72444 support multiple dso type values in discovery Support multiple dso type values in discovery Aug 27, 2020
@artlowel artlowel added this to Needs Reviewers Assigned in DSpace 7 Beta 4 Aug 27, 2020
@tdonohue tdonohue added this to the 7.0beta4 milestone Aug 27, 2020
@tdonohue tdonohue added component: Discovery related to discovery search or browse system improvement 1 APPROVAL pull request only requires a single approval to merge labels Aug 27, 2020
@tdonohue tdonohue self-requested a review August 27, 2020 14:50
@tdonohue tdonohue moved this from Needs Reviewers Assigned to Under Review in DSpace 7 Beta 4 Aug 27, 2020
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great, @MarieVerdonck ! Code looks good. I tested the searches and they all seem to still work. I also verified that the Export Metadata feature now only searches Communities & Collections (previously it also searched Items). Thanks!

DSpace 7 Beta 4 automation moved this from Under Review to Reviewer Approved Aug 28, 2020
@tdonohue tdonohue merged commit a63bfdf into DSpace:main Aug 28, 2020
DSpace 7 Beta 4 automation moved this from Reviewer Approved to Done Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge component: Discovery related to discovery search or browse system improvement
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants