Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of email option for the curation script #855

Merged
merged 1 commit into from Sep 2, 2020

Conversation

jonas-atmire
Copy link
Contributor

References

Description

This PR will remove the "email/-e" option from the curate script on Angular's end. See linked PR for REST related info.

Instructions for Reviewers

In the CurationFormComponent:

  • All authentication related code is removed
    • authService and it's related calls are removed
    • The -e option is not added to the call anymore

In the related test component

  • -e option is not added anymore
  • unused code is cleaned up

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

@jonas-atmire jonas-atmire added this to Needs Reviewers Assigned in DSpace 7 Beta 4 Sep 2, 2020
@artlowel artlowel added the 1 APPROVAL pull request only requires a single approval to merge label Sep 2, 2020
@tdonohue tdonohue self-requested a review September 2, 2020 13:49
@tdonohue tdonohue moved this from Needs Reviewers Assigned to Under Review in DSpace 7 Beta 4 Sep 2, 2020
@tdonohue tdonohue added this to the 7.0beta4 milestone Sep 2, 2020
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Code changes look good. Tested with DSpace/DSpace#2926 and it works as expected now! Thanks @jonas-atmire

DSpace 7 Beta 4 automation moved this from Under Review to Reviewer Approved Sep 2, 2020
@tdonohue tdonohue merged commit 16a68da into DSpace:main Sep 2, 2020
DSpace 7 Beta 4 automation moved this from Reviewer Approved to Done Sep 2, 2020
dsipos-dev added a commit to qultoltd/dspace-angular that referenced this pull request Oct 9, 2020
4science-it pushed a commit to 4Science/dspace-angular that referenced this pull request Oct 11, 2023
[DSC-1251] consider empty value of configuration key request.item.type

Approved-by: Vincenzo Mecca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge tools: curation-tasks
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants