Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug concerning bistream pagination on the item page #873

Merged

Conversation

YanaDePauw
Copy link
Contributor

@YanaDePauw YanaDePauw commented Sep 23, 2020

References

This is a fix to an issue introduced in #838

This PR fixes an issue that is visible in the browser console when loading an item without any bitstreams: example

Description

  • Fix an issue with the bitstream loading on the item page when no bitstreams are present
  • Add an error notification when an error occurs with retrieving the item bitstreams
  • Hide the labels for empty bundles on the full item page

Instructions for Reviewers

  • Navigate to an item without any bitstreams
  • Verify that no error message is shown in the browser console and that the page fully loads
  • Verify that the full item page doesn't show labels for empty bundles
  • Verify that loading extra pages of bitstreams on the simple or full item pages is not affected by this fix

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

@artlowel artlowel added the 1 APPROVAL pull request only requires a single approval to merge label Sep 23, 2020
@artlowel artlowel added this to Needs Reviewers Assigned in DSpace 7 Beta 4 via automation Sep 23, 2020
@artlowel artlowel added this to the 7.0beta4 milestone Sep 23, 2020
@tdonohue tdonohue self-requested a review September 24, 2020 14:21
@tdonohue tdonohue added the bug label Sep 24, 2020
@tdonohue tdonohue moved this from Needs Reviewers Assigned to Under Review in DSpace 7 Beta 4 Sep 24, 2020
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Code looks good to me. I also tested this and it works well both when there are bitstreams and when there are not. Thanks @YanaDePauw !

DSpace 7 Beta 4 automation moved this from Under Review to Reviewer Approved Sep 29, 2020
@tdonohue tdonohue merged commit c67d2e6 into DSpace:main Sep 29, 2020
DSpace 7 Beta 4 automation moved this from Reviewer Approved to Done Sep 29, 2020
@tdonohue tdonohue mentioned this pull request Sep 29, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants